Re: [quicwg/base-drafts] First set of Gorry's nits (#3742)

Jana Iyengar <notifications@github.com> Tue, 09 June 2020 07:56 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 904D13A0AA8 for <quic-issues@ietfa.amsl.com>; Tue, 9 Jun 2020 00:56:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.101
X-Spam-Level:
X-Spam-Status: No, score=-3.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mdG_vJMrz0BM for <quic-issues@ietfa.amsl.com>; Tue, 9 Jun 2020 00:56:11 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D2FC23A0AA1 for <quic-issues@ietf.org>; Tue, 9 Jun 2020 00:56:10 -0700 (PDT)
Received: from github-lowworker-ca235ff.ash1-iad.github.net (github-lowworker-ca235ff.ash1-iad.github.net [10.56.110.15]) by smtp.github.com (Postfix) with ESMTP id EB3288C0E33 for <quic-issues@ietf.org>; Tue, 9 Jun 2020 00:56:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1591689369; bh=tl0dwxFbFkIfTMHbetw52BgPGT1JnIBrdgHzlD4vfVc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oFrhXqW74PhKGw6pgvnaGCt6BDTEnT61psneAhzcxbZAZyFnxSSfo4tZ4u3LjGYrE 44GF6QErjyV96vDguAqhl5ucXf5L5uv1O3LVrSZET1osIJcURFSTBbhK89OozRHWs8 7qqW8DtwJSUOYoOBQlAS/Qa+bVKP4WvCgv3NFL6o=
Date: Tue, 09 Jun 2020 00:56:09 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3C4FRNN3UYMEKP2V545MQZTEVBNHHCLW3T44@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3742/review/426871085@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3742@github.com>
References: <quicwg/base-drafts/pull/3742@github.com>
Subject: Re: [quicwg/base-drafts] First set of Gorry's nits (#3742)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5edf4099dc03e_77ad3f84142cd968571e5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/BTzoKja5Sia0m5ZQoWZFLGJunGY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jun 2020 07:56:14 -0000

@janaiyengar commented on this pull request.

A few suggestions.

> @@ -665,15 +665,16 @@ STREAM_DATA_BLOCKED ({{frame-stream-data-blocked}}), and RESET_STREAM
 ({{frame-reset-stream}}).
 
 A sender MUST NOT send any of these frames from a terminal state ("Data Recvd"
-or "Reset Recvd").  A sender MUST NOT send STREAM or STREAM_DATA_BLOCKED after
-sending a RESET_STREAM; that is, in the terminal states and in the "Reset Sent"
-state.  A receiver could receive any of these three frames in any state, due to
-the possibility of delayed delivery of packets carrying them.
+or "Reset Recvd").  A sender MUST NOT send a STREAM or STREAM_DATA_BLOCKED frame
+for a stream in the "Reset Sent" state or any terminal state; that is, after

```suggestion
for a stream in the "Reset Sent" state or any terminal state, that is, after
```

> @@ -1186,8 +1189,8 @@ that packet.
 If a server receives a packet that has an unsupported version, but the packet is

```suggestion
If a server receives a packet that indicates an unsupported version but is large
```

> @@ -1186,8 +1189,8 @@ that packet.
 If a server receives a packet that has an unsupported version, but the packet is
 sufficiently large to initiate a new connection for any version supported by the

```suggestion
enough to initiate a new connection for any one supported version,
```

> @@ -1186,8 +1189,8 @@ that packet.
 If a server receives a packet that has an unsupported version, but the packet is
 sufficiently large to initiate a new connection for any version supported by the
 server, it SHOULD send a Version Negotiation packet as described in

```suggestion
the server SHOULD send a Version Negotiation packet as described in
```

> +consist of as few as 4 UDP datagrams, or any number more up to the limits
+inherent to the protocol, such as congestion control or anti-amplification.  For

```suggestion
consist of as few as 4 UDP datagrams, or any number more (subject to limits
inherent to the protocol, such as congestion control or anti-amplification).  For
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3742#pullrequestreview-426871085