Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCEEDED when overflowing a CRYPTO frame (#3186)

ianswett <notifications@github.com> Mon, 04 November 2019 21:49 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BFF21120B33 for <quic-issues@ietfa.amsl.com>; Mon, 4 Nov 2019 13:49:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.454
X-Spam-Level:
X-Spam-Status: No, score=-6.454 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W7PcEtbf8epE for <quic-issues@ietfa.amsl.com>; Mon, 4 Nov 2019 13:49:07 -0800 (PST)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B96BB120AD6 for <quic-issues@ietf.org>; Mon, 4 Nov 2019 13:48:59 -0800 (PST)
Date: Mon, 04 Nov 2019 13:48:59 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572904139; bh=eFvdsMyQ9DCMlMHdnOrP7kkxPPpClHlSSSu8S6vkb8w=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=P8cIseg1BG0z4yKNcVOjIuqI9knzVUH2YkfzTmSorWZBSTeXkTJxIQGXCtQofF3QP AXhgYI1izmq3jOxzGiH7S1ni2jjzK1c2/3IjSMkyGoSCN8/C7m7sEzxZP08vaMpEor KzNdrjb9PUJ5MzNesTMqoQdiDsCFXSXfVHoUGSgI=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2U6EG3Z45GLRH4UHV3ZXHUXEVBNHHB5UBVKI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3186/review/311381191@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3186@github.com>
References: <quicwg/base-drafts/pull/3186@github.com>
Subject: Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCEEDED when overflowing a CRYPTO frame (#3186)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dc09ccbfa22_43293fd2deacd960346181"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/BV618OjFXdyIgtwWl1ATPAWcT1Y>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Nov 2019 21:49:12 -0000

ianswett requested changes on this pull request.

Actually, I thought the principle we have is that if you could identify a frame as being invalid with no other information, it should be a FRAME_ENCODING_ERROR, so the existing text is correct?



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3186#pullrequestreview-311381191