Re: [quicwg/base-drafts] Don't recommend 3 RTTs of credit (and other editorial) (#3301)

Jana Iyengar <notifications@github.com> Fri, 20 December 2019 03:52 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 18EC4120BEE for <quic-issues@ietfa.amsl.com>; Thu, 19 Dec 2019 19:52:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QG6kUt7lcqPL for <quic-issues@ietfa.amsl.com>; Thu, 19 Dec 2019 19:52:34 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 69AF2120B77 for <quic-issues@ietf.org>; Thu, 19 Dec 2019 19:52:34 -0800 (PST)
Received: from github-lowworker-d93c4b6.va3-iad.github.net (github-lowworker-d93c4b6.va3-iad.github.net [10.48.17.47]) by smtp.github.com (Postfix) with ESMTP id 60CC7960613 for <quic-issues@ietf.org>; Thu, 19 Dec 2019 19:52:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1576813953; bh=fC4PTAw0hqGWD6v7XTM0jcPcHngeoxOwphKt+oODY8A=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=i2KzoVqWqpoeFBagRKvO1Q7g9VgKWG2jEmDnDugwmYS6LkgfqPezdQwPbObF7zkwR AdSchGoJOeH5PnUMO4L16CJSNYWZbrolNlxxeeG1KdshguiKbDFK3f/8rEPLWg2hN8 bHyqWwmzECdR6hfmSf1ckhxS36nOQb6CmWtg5Okw=
Date: Thu, 19 Dec 2019 19:52:33 -0800
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK32LJMI4ZDDUF2U54N4BF4ADEVBNHHCADX3MM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3301/review/335057395@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3301@github.com>
References: <quicwg/base-drafts/pull/3301@github.com>
Subject: Re: [quicwg/base-drafts] Don't recommend 3 RTTs of credit (and other editorial) (#3301)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dfc4581471f9_11b23fb9442cd96c1125e1"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Bc7ZkXKio1beBW5Td9XylXO7pqs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Dec 2019 03:52:39 -0000

janaiyengar commented on this pull request.



> @@ -801,33 +801,37 @@ limit is increased.
 
 ## Flow Credit Increments {#fc-credit}

That seems too general. I'm not in love with what we have, but I prefer it because it's more specific.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3301#discussion_r360218670