Re: [quicwg/base-drafts] Let Endpoints Ignore invalid Initial Packets (#1819)
ianswett <notifications@github.com> Tue, 02 October 2018 01:12 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0C4C01274D0 for <quic-issues@ietfa.amsl.com>; Mon, 1 Oct 2018 18:12:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.456
X-Spam-Level:
X-Spam-Status: No, score=-8.456 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oXTFCpPnlxiF for <quic-issues@ietfa.amsl.com>; Mon, 1 Oct 2018 18:12:03 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 939C2126CB6 for <quic-issues@ietf.org>; Mon, 1 Oct 2018 18:12:03 -0700 (PDT)
Date: Mon, 01 Oct 2018 18:12:02 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1538442722; bh=iFhqG7ajJHpwXDvvt0ks9mgwqzJkKCXfYQGYbxm5J50=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=eRku5SxXKAnTvqn6M1l7dNkXAMG+gTuJKJuARHp8+RkZAdEbbrm7RiLCvhXbEa/OZ SDb5tIvG7ADqBAXS2YXkq4BPQjVc1CZ772rQi5a4Ve9q2xNJTFZ0k50pqYut/T3lxt IUX2HAl+04xAjl8zP+tARs9G2E/1BzIWnYDW/UuA=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab9774a63e55f2830f9a5ab7570cd9780c6629c68e92cf0000000117ca87e292a169ce15cbb1a4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1819/review/160539210@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1819@github.com>
References: <quicwg/base-drafts/pull/1819@github.com>
Subject: Re: [quicwg/base-drafts] Let Endpoints Ignore invalid Initial Packets (#1819)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bb2c5e24f671_15813fc82e0d45b820899"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Bfey-PJkERO4z9NA9UPU0beZfQI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Oct 2018 01:12:05 -0000
ianswett commented on this pull request. Looks good, one comment about the text you're modifying. > @@ -720,9 +720,7 @@ require multiple round trips or retransmissions of this data. The payload of an Initial packet includes a CRYPTO frame (or frames) containing I think "containing a cryptographic handshake message" section makes this sentence more confusing. Can you remove it? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1819#pullrequestreview-160539210
- [quicwg/base-drafts] Let Endpoints Ignore invalid… martinduke
- Re: [quicwg/base-drafts] Let Endpoints Ignore inv… martinduke
- Re: [quicwg/base-drafts] Let Endpoints Ignore inv… ianswett
- Re: [quicwg/base-drafts] Let Endpoints Ignore inv… martinduke
- Re: [quicwg/base-drafts] Let Endpoints Ignore inv… martinduke
- Re: [quicwg/base-drafts] Let Endpoints Ignore inv… Mike Bishop
- Re: [quicwg/base-drafts] Let Endpoints Ignore inv… martinduke
- Re: [quicwg/base-drafts] Let Endpoints Ignore inv… martinduke
- Re: [quicwg/base-drafts] Let Endpoints Ignore inv… ianswett
- Re: [quicwg/base-drafts] Let Endpoints Ignore inv… MikkelFJ
- Re: [quicwg/base-drafts] Let Endpoints Ignore inv… ianswett
- Re: [quicwg/base-drafts] Let Endpoints Ignore inv… martinduke
- Re: [quicwg/base-drafts] Let Endpoints Ignore inv… Martin Thomson
- Re: [quicwg/base-drafts] Let Endpoints Ignore inv… martinduke
- Re: [quicwg/base-drafts] Let Endpoints Ignore inv… Martin Thomson
- Re: [quicwg/base-drafts] Let Endpoints Ignore inv… Martin Thomson