Re: [quicwg/base-drafts] Frame special rules (#3776)

Jana Iyengar <notifications@github.com> Thu, 18 June 2020 21:57 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CB89E3A0CD7 for <quic-issues@ietfa.amsl.com>; Thu, 18 Jun 2020 14:57:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.1
X-Spam-Level:
X-Spam-Status: No, score=-3.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YOqvciIMQCyE for <quic-issues@ietfa.amsl.com>; Thu, 18 Jun 2020 14:57:56 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B4CA83A0C82 for <quic-issues@ietf.org>; Thu, 18 Jun 2020 14:57:56 -0700 (PDT)
Received: from github-lowworker-f144ac1.va3-iad.github.net (github-lowworker-f144ac1.va3-iad.github.net [10.48.16.59]) by smtp.github.com (Postfix) with ESMTP id F1F4CA0BBB for <quic-issues@ietf.org>; Thu, 18 Jun 2020 14:57:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1592517475; bh=KqQyLaoD0z/SrEYJwL89p2j7R5a4mdb2NoXGxg61/T0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=VdFhtYjGRCU4Cnji4u2va9tIKczrPmO8k/6FgtD9kJMw1QL1dOTbEbys8J64MrCXT aZFxF7ExW+mF//rqbsG8g3bFINRO1tDWpgJQ8hgIOCflo6MMcVfriZEiqYhkoHyf5t o9vqVhI/rNySDNMoTc60nTlk5Aeapg08CH9PM0vs=
Date: Thu, 18 Jun 2020 14:57:55 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7GUNX3SYMVKJD6FKV467CGHEVBNHHCMMUNOM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3776/review/433672736@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3776@github.com>
References: <quicwg/base-drafts/pull/3776@github.com>
Subject: Re: [quicwg/base-drafts] Frame special rules (#3776)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5eebe363e2153_7e63fa385ecd96c20178e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/BhEyIr_dKs5UnLj5LgASJM_dBmM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jun 2020 21:57:58 -0000

@janaiyengar commented on this pull request.

I like this a lot! I know there are just one frame type for C and F, but I have an editorial suggestion that just makes it more uniform and easier to read IMO.

> +: Packets containing only ACK frames do not count toward bytes in flight for
+  congestion control purposes; see {{QUIC-RECOVERY}}.

```suggestion
: Packets containing only frames with this marking do not count toward bytes
  in flight for congestion control purposes; see {{QUIC-RECOVERY}}.
```

> +characters:
+
+N:
+: Packets containing only frames with this marking are not ack-eliciting; see
+  {{generating-acks}}.
+
+C:
+: Packets containing only ACK frames do not count toward bytes in flight for
+  congestion control purposes; see {{QUIC-RECOVERY}}.
+
+P:
+: Packets containing only frames with this marking can be used to probe new
+  network paths during connection migration; see {{probing}}.
+
+F:
+: The content of the STREAM frame are flow controlled; see {{flow-control}}.

```suggestion
: The content of frames with this marking are flow controlled; see {{flow-control}}.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3776#pullrequestreview-433672736