Date: Thu, 18 Jun 2020 14:57:55 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK7GUNX3SYMVKJD6FKV467CGHEVBNHHCMMUNOM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3776/review/433672736@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3776@github.com>
References: <quicwg/base-drafts/pull/3776@github.com>
Subject: Re: [quicwg/base-drafts] Frame special rules (#3776)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5eebe363e2153_7e63fa385ecd96c20178e";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/BhEyIr_dKs5UnLj5LgASJM_dBmM>


----==_mimepart_5eebe363e2153_7e63fa385ecd96c20178e
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@janaiyengar commented on this pull request.

I like this a lot! I know there are just one frame type for C and F, but I have an editorial suggestion that just makes it more uniform and easier to read IMO.

> +: Packets containing only ACK frames do not count toward bytes in flight for
+  congestion control purposes; see {{QUIC-RECOVERY}}.

```suggestion
: Packets containing only frames with this marking do not count toward bytes
  in flight for congestion control purposes; see {{QUIC-RECOVERY}}.
```

> +characters:
+
+N:
+: Packets containing only frames with this marking are not ack-eliciting; see
+  {{generating-acks}}.
+
+C:
+: Packets containing only ACK frames do not count toward bytes in flight for
+  congestion control purposes; see {{QUIC-RECOVERY}}.
+
+P:
+: Packets containing only frames with this marking can be used to probe new
+  network paths during connection migration; see {{probing}}.
+
+F:
+: The content of the STREAM frame are flow controlled; see {{flow-control}}.

```suggestion
: The content of frames with this marking are flow controlled; see {{flow-control}}.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3776#pullrequestreview-433672736
----==_mimepart_5eebe363e2153_7e63fa385ecd96c20178e
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p></p>=0D
<p><b>@janaiyengar</b> commented on this pull request.</p>=0D
=0D
<p>I like this a lot! I know there are just one frame type for C and F, b=
ut I have an editorial suggestion that just makes it more uniform and eas=
ier to read IMO.</p><hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/3776#discussi=
on_r442522548">draft-ietf-quic-transport.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; +: Packets containing only ACK frames do n=
ot count toward bytes in flight for=0D
+  congestion control purposes; see {{QUIC-RECOVERY}}.=0D
</pre>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-: Packets containing only ACK frames do not c=
ount toward bytes in flight for=0D
-  congestion control purposes; see {{QUIC-RECOVERY}}.=0D
+: Packets containing only frames with this marking do not count toward b=
ytes=0D
+  in flight for congestion control purposes; see {{QUIC-RECOVERY}}.=0D
</pre>=0D
=0D
=0D
<hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/3776#discussi=
on_r442523030">draft-ietf-quic-transport.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; +characters:=0D
+=0D
+N:=0D
+: Packets containing only frames with this marking are not ack-eliciting=
; see=0D
+  {{generating-acks}}.=0D
+=0D
+C:=0D
+: Packets containing only ACK frames do not count toward bytes in flight=
 for=0D
+  congestion control purposes; see {{QUIC-RECOVERY}}.=0D
+=0D
+P:=0D
+: Packets containing only frames with this marking can be used to probe =
new=0D
+  network paths during connection migration; see {{probing}}.=0D
+=0D
+F:=0D
+: The content of the STREAM frame are flow controlled; see {{flow-contro=
l}}.=0D
</pre>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-: The content of the STREAM frame are flow co=
ntrolled; see {{flow-control}}.=0D
+: The content of frames with this marking are flow controlled; see {{flo=
w-control}}.=0D
</pre>=0D
=0D
=0D
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/3776#pullrequestreview-433672736">view it on GitHub</=
a>, or <a href=3D"https://github.com/notifications/unsubscribe-auth/AFTOJ=
KZSS7L2RYWSILZHBMTRXKEWHANCNFSM4OBD7GHQ">unsubscribe</a>.<img src=3D"http=
s://github.com/notifications/beacon/AFTOJK5NLOFX7MI4VNOXBLLRXKEWHA5CNFSM4=
OBD7GH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZ=
GODHMVEIA.gif" height=3D"1" width=3D"1" alt=3D"" /></p>=0D
<script type=3D"application/ld+json">[=0D
{=0D
"@context": "http://schema.org",=0D
"@type": "EmailMessage",=0D
"potentialAction": {=0D
"@type": "ViewAction",=0D
"target": "https://github.com/quicwg/base-drafts/pull/3776#pullrequestrev=
iew-433672736",=0D
"url": "https://github.com/quicwg/base-drafts/pull/3776#pullrequestreview=
-433672736",=0D
"name": "View Pull Request"=0D
},=0D
"description": "View this Pull Request on GitHub",=0D
"publisher": {=0D
"@type": "Organization",=0D
"name": "GitHub",=0D
"url": "https://github.com"=0D
}=0D
}=0D
]</script>=

----==_mimepart_5eebe363e2153_7e63fa385ecd96c20178e--