IETF Logo Mail Archive

Re: [quicwg/base-drafts] Martin Duke's QPACK comments (#4750)

Martin Thomson <notifications@github.com> Tue, 19 January 2021 20:48 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E1D6B3A11EF for <quic-issues@ietfa.amsl.com>; Tue, 19 Jan 2021 12:48:25 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 3.177
X-Spam-Level: ***
X-Spam-Status: No, score=3.177 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, GB_SUMOF=5, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qP2X5elRhZw4 for <quic-issues@ietfa.amsl.com>; Tue, 19 Jan 2021 12:48:24 -0800 (PST)
Received: from smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 757593A0AC4 for <quic-issues@ietf.org>; Tue, 19 Jan 2021 12:48:22 -0800 (PST)
Received: from github.com (hubbernetes-node-72d8ae7.ash1-iad.github.net [10.56.112.60]) by smtp.github.com (Postfix) with ESMTPA id B6F905E0048 for <quic-issues@ietf.org>; Tue, 19 Jan 2021 12:48:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1611089301; bh=lJTgPA8cxPYbi6al4vNBRmo2lJIxQQblouK2qfmzo2Y=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=cWZ+y9e5qkZcwdRANXOBAIpNWCcJSaQOVDX8FoU0nIhCDK4ncU5FExyZSxqLqduc7 AOq4LHETCxtUBlNRiDji8UkBwpbhxO8RtnnOpk10gdR3CggEitaNgc0JqUgnf4bVXF kvlkigeO8A6NDBtRUCV0nhjw0OuxxemtOXmxC9Q0=
Date: Tue, 19 Jan 2021 12:48:21 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3ZRF6Z4H56PSREXDN6CMTJLEVBNHHC6CKWHQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4750/review/571646255@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4750@github.com>
References: <quicwg/base-drafts/pull/4750@github.com>
Subject: Re: [quicwg/base-drafts] Martin Duke's QPACK comments (#4750)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_60074595b390d_66d1a0492555"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Bkqn4Dgpl9-7bD5-JP-Fv2Fe2aQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jan 2021 20:48:26 -0000

@martinthomson approved this pull request.



> @@ -486,8 +487,8 @@ Dynamic table entries can have empty values.
 The size of the dynamic table is the sum of the size of its entries.
 
 The size of an entry is the sum of its name's length in bytes, its value's
-length in bytes, and 32.  The size of an entry is calculated using the length of
-its name and value without Huffman encoding applied.
+length in bytes, and 32 bytes.  The size of an entry is calculated using the

You could say 32 additional bytes even.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4750#pullrequestreview-571646255

v2.23.0 | Report a Bug | By Email