Re: [quicwg/base-drafts] HTTP SETTINGS: define setting content encoding (#1556)

Luca Niccolini <> Mon, 16 July 2018 22:23 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 7C618130F09 for <>; Mon, 16 Jul 2018 15:23:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id nCq2NIEhNbbV for <>; Mon, 16 Jul 2018 15:23:50 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 3933A12F1A5 for <>; Mon, 16 Jul 2018 15:23:50 -0700 (PDT)
Date: Mon, 16 Jul 2018 15:23:49 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1531779829; bh=9iMiKm5lO5RhgNIiuemWtL0JmImWaUAlbE+RjKt0amY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SoPbR3b+zhu+cBrEydLiHSSA/OHs9zQn3UEvuIcrmSyNJE6HlcCPyR+K6LmciOj9n vmvVJmaBIn+fE9QGt7D2EpcudPYFO1hdgLk/WUGipSyikDT7hjI3nqJQkL6fK+Askm Ob6RFvapNXUq5xqO+AYDrODgkPI4NHC11Pl5Cl5Q=
From: Luca Niccolini <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/issues/1556/>
In-Reply-To: <quicwg/base-drafts/issues/>
References: <quicwg/base-drafts/issues/>
Subject: Re: [quicwg/base-drafts] HTTP SETTINGS: define setting content encoding (#1556)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b4d1af528fbe_4c302af6ec580f581282f8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: lnicco
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Mon, 16 Jul 2018 22:23:53 -0000

ouch! I totally missed section and I think (as you pointed out) the fact that we have a length field before a varint that also includes the length threw me off. 

@LPardue, FYI: I was looking at your implementation and it seems that you also made my same assumption that integers are 4-bytes long

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: