IETF Logo Mail Archive

Re: [quicwg/base-drafts] Auth48 fixes for QPACK (PR #4986)

Mike Bishop <notifications@github.com> Wed, 27 April 2022 13:53 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A581AC23BED5 for <quic-issues@ietfa.amsl.com>; Wed, 27 Apr 2022 06:53:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.662
X-Spam-Level:
X-Spam-Status: No, score=-3.662 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.575, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EcIU6qWqC-xN for <quic-issues@ietfa.amsl.com>; Wed, 27 Apr 2022 06:53:37 -0700 (PDT)
Received: from smtp.github.com (out-25.smtp.github.com [192.30.252.208]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 166F2C07C72E for <quic-issues@ietf.org>; Wed, 27 Apr 2022 06:53:16 -0700 (PDT)
Received: from github-lowworker-f045d1f.ac4-iad.github.net (github-lowworker-f045d1f.ac4-iad.github.net [10.52.19.54]) by smtp.github.com (Postfix) with ESMTP id 2D21F840EDC for <quic-issues@ietf.org>; Wed, 27 Apr 2022 06:53:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1651067595; bh=53eKukUBQiDhT5M/UcMW3Fkx4W2d1sI2JVN2GJjDE7Y=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oViNci6O5GlxuokNvPCBcWkmahiluEcqyGleXI5qqP3nP76PY32pYhZ+mq9hbyXiw 40S7Lt4PcIizbo51bjlYAM/80nsyzXv56eYer8xmQXJm5Ec3H0llSKCDyLuCLCm4Kc Ut7Vkqyd4pags4HXjQJSweQA2XmluCujvdcXcOVs=
Date: Wed, 27 Apr 2022 06:53:15 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYBSYFOZND6HD6YTC6AOZ6UXEVBNHHEQ73GEU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4986/review/954945937@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4986@github.com>
References: <quicwg/base-drafts/pull/4986@github.com>
Subject: Re: [quicwg/base-drafts] Auth48 fixes for QPACK (PR #4986)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_62694acb1e126_35ed41c811555"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/BndyEGD6hiZg50SRfAgaRAAf34k>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.34
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Apr 2022 13:53:38 -0000

@MikeBishop commented on this pull request.



> +<aside><t>
+Note: Padding schemes only provide limited protection against an attacker with
+these capabilities, potentially only forcing an increased number of guesses to
+learn the length associated with a given guess. Padding schemes also work
+directly against compression by increasing the number of bits that are
+transmitted.
+</t></aside>

Hm, that produces `<t gi="aside">` in the XML, which then doesn't build for me.  It looks like blockquote also produces a `gi`, which is then stripped by `convert_blockquote()` if `$options.v3` is set.  I don't see anything corresponding for `aside`, but I don't know if there should be.

I've tried a couple other variations without success, so I think we would need @cabo to give us the correct invocation.  
Or we just keep the XML tags.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4986#discussion_r859829070
You are receiving this because you are subscribed to this thread.

Message ID: <quicwg/base-drafts/pull/4986/review/954945937@github.com>

v2.8.7 | Report a Bug | By Email