Re: [quicwg/base-drafts] Fixed handshake key deadlock issue (#3093)

ianswett <notifications@github.com> Tue, 22 October 2019 01:28 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AF5F1120ABC for <quic-issues@ietfa.amsl.com>; Mon, 21 Oct 2019 18:28:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q6dQvtsqs_9u for <quic-issues@ietfa.amsl.com>; Mon, 21 Oct 2019 18:28:40 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2FB21120AA0 for <quic-issues@ietf.org>; Mon, 21 Oct 2019 18:28:40 -0700 (PDT)
Date: Mon, 21 Oct 2019 18:28:39 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571707719; bh=EHCRJ4rpd5YfEeR/aSj8NiLZF8BMykTBXydx2xPpDv0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oYNyl+YexlJ05rs/wwtcHvAUQLEMgm3mzUO6Y+Q2okm8ygEyf3ntEHAVH0F6Lyiwm JfFfEy0/cPH9o2Eaq/eUZ42ExLToxkCxE6hjAnLY6XaAaINvPHC4AogkUCkVQrsmwF NubSZxfkV2AnTGF4bTNBGkVbd47DGHN2His94SwI=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKY245FH4F4W6Y5KBOV3XON5PEVBNHHB4OJ3YQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3093/c544772965@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3093@github.com>
References: <quicwg/base-drafts/pull/3093@github.com>
Subject: Re: [quicwg/base-drafts] Fixed handshake key deadlock issue (#3093)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dae5b477cd0a_7fa83fe1e4ccd96c1137fe"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/BqhA1hJ0tETK_bhMk0sTuLmwQmw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Oct 2019 01:28:42 -0000

Thanks for the diagram, and I'm happy to stick with the approach of keeping the keys forever.

If we change nothing about the existing text, what you describe occurs, but as I suggested elsewhere, if we are going to delay dropping the Handshake keys(somewhat or indefinitely), I think we should update the text of transport or recovery to be clear that you can stop retransmitting any outstanding data in Handshake once you've received a 1-RTT ACK.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3093#issuecomment-544772965