Re: [quicwg/base-drafts] Clarify QPACK eviction races (#1237)
Martin Thomson <notifications@github.com> Mon, 19 March 2018 14:07 UTC
Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BB504126DEE for <quic-issues@ietfa.amsl.com>; Mon, 19 Mar 2018 07:07:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.01
X-Spam-Level:
X-Spam-Status: No, score=-2.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wRGp2bwWF19Q for <quic-issues@ietfa.amsl.com>; Mon, 19 Mar 2018 07:07:49 -0700 (PDT)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5B5BE126E64 for <quic-issues@ietf.org>; Mon, 19 Mar 2018 07:07:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=DVxLzP78vJdJdCy8VARQuTttdTs=; b=RoRQIeeg4z28pBng rOyOtsaLHVCR/tBJlVcVvgvpnR7GsfRbB/T48r69aDAAWmfHiE4Z640n0gBbeGV5 S2FgD5mQJ+oHoNmNAYvjzjiMEGV77KPR7Or/3vS3hyRMj44XFDtLMRePHc7qs6Be qGiXZ+U7bpBzMhuwIkc+NDans7I=
Received: by filter0553p1las1.sendgrid.net with SMTP id filter0553p1las1-12350-5AAFC432-3A 2018-03-19 14:07:46.78321155 +0000 UTC
Received: from smtp.github.com (out-5.smtp.github.com [192.30.252.196]) by ismtpd0006p1iad1.sendgrid.net (SG) with ESMTP id Zq9ftCA4TvO6vRJZSCwk4Q for <quic-issues@ietf.org>; Mon, 19 Mar 2018 14:07:46.522 +0000 (UTC)
Date: Mon, 19 Mar 2018 14:07:46 +0000
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab59a7fcd4dcb0be2711fa7fc1b9f13cfa6965997f92cf0000000116c7863292a169ce12443a1c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1237/review/104974911@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1237@github.com>
References: <quicwg/base-drafts/pull/1237@github.com>
Subject: Re: [quicwg/base-drafts] Clarify QPACK eviction races (#1237)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aafc4325ea25_5f2a2ab5cb526ed42314f0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak145wn9a0qHa6xVukBUU7Cid58d43CeoUnkGG +U1oiwiAYETU8WiXcygJPYEGyXbKiXSpYatBkgkUnSFDI/wNvisH2ZN+BgZW/2QE0hSeKITiigpceI IWqvGWvLoxFBKAgkWr/1ynkXFYlpxR4PcZR8A+BoOHYDnp0EmSSvhQwiaWfCaF7tltjlIaULIjAyhe k=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/BrcfT_-2ruYqhl7P90FskCEp760>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Mar 2018 14:07:52 -0000
martinthomson commented on this pull request.
> desired.
-To ensure that the blocked eviction case is rare, references to the oldest
-entries in the dynamic table SHOULD be avoided. When one of the oldest entries
-in the table is still actively used for references, the encoder SHOULD emit an
-Indexed-Duplicate representation instead (see {{indexed-duplicate}}).
+To ensure that blocked evictions are rare, the encoder SHOULD avoid
+referencing any eviction-prone entries, which are dynamic table entries that may
+be evicted soon. Rather than reference an eviction-prone entry, the encoder
+SHOULD emit an Indexed-Duplicate representation (see {{indexed-duplicate}}),
+and reference the duplicate instead.
+
+To identify eviction-prone entries, the encoder may maintain a draining index,
+which is the smallest index in the dynamic table that it will emit a
+reference for. As new entries are inserted, the encoder increments the
+draining index such that the amount of free and draining space in the dyanmic
+table is larger than its target threshold.
I'm fairly stupid during meetings that I pay attention to, but I didn't follow this last paragraph very well. Smallest implies small numbers, but I think that you mean smallest "base" (which is the inverse of indices).
I probably don't really understand what you are trying to say, so consider tweaking for clarity. That might mean more text.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1237#pullrequestreview-104974911
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Mike Bishop
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- [quicwg/base-drafts] Clarify QPACK eviction races… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Mike Bishop
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Mike Bishop
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Mike Bishop
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind