Re: [quicwg/base-drafts] Rephrase text in PLPMTUD (#1337)
ianswett <notifications@github.com> Fri, 04 May 2018 01:53 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D672D12D941 for <quic-issues@ietfa.amsl.com>; Thu, 3 May 2018 18:53:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r12eKaekkG4g for <quic-issues@ietfa.amsl.com>; Thu, 3 May 2018 18:53:46 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F172B12D889 for <quic-issues@ietf.org>; Thu, 3 May 2018 18:53:45 -0700 (PDT)
Date: Thu, 03 May 2018 18:53:45 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1525398825; bh=+Gp6pz+30e/yXFVJx9nzxPYnfPaAi9LoPBYt+I6gIgc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ZM0TT36Ll5utSNsbvIt7QQxnvVLCTL48aI5SilMBV+nB/nl+SrvYnTNVtXodUET5T LPOF+HBMucG27H3ts4TEiBuHzZo+TRi/mWxI+MpvWb534y9KL9CP2qU0j4jCH3yHLC wn6QhKVGxi0yGC1UKJ/jZRoeaE9C+OFAisEcsCdU=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab060edc8fc8672090564494131704023266753f4392cf0000000117037f2992a169ce1314bed4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1337/review/117479345@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1337@github.com>
References: <quicwg/base-drafts/pull/1337@github.com>
Subject: Re: [quicwg/base-drafts] Rephrase text in PLPMTUD (#1337)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aebbd2956a4a_487a3fa85f55af7c372ac"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Bs0p8qdvsBBopj8apxtWH2lg1kI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 04 May 2018 01:53:48 -0000
ianswett approved this pull request. LG, but two editorial comments. > @@ -3088,11 +3088,11 @@ actually lost. The PADDING frame provides a useful option for PMTU probe packets that does not nit: Other transports don't have padding? > @@ -3088,11 +3088,11 @@ actually lost. The PADDING frame provides a useful option for PMTU probe packets that does not -exist in other transports. PADDING frames generate acknowledgements, but their -content need not be delivered reliably. PADDING frames may delay the delivery of -application data, as they consume the congestion window. However, by definition -their likely loss in a probe packet does not require delay-inducing -retransmission of application data. +exist in other transports. PADDING frames generate acknowledgements, but they +need not be delivered reliably. As a result, the likely loss of PADDING frames nit: likely is speculative, I'd remove it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1337#pullrequestreview-117479345
- [quicwg/base-drafts] Rephrase text in PLPMTUD (#1… janaiyengar
- Re: [quicwg/base-drafts] Rephrase text in PLPMTUD… ianswett
- Re: [quicwg/base-drafts] Rephrase text in PLPMTUD… Martin Thomson
- Re: [quicwg/base-drafts] Rephrase text in PLPMTUD… Lucas Pardue
- Re: [quicwg/base-drafts] Rephrase text in PLPMTUD… janaiyengar
- Re: [quicwg/base-drafts] Rephrase text in PLPMTUD… janaiyengar
- Re: [quicwg/base-drafts] Rephrase text in PLPMTUD… janaiyengar
- Re: [quicwg/base-drafts] Rephrase text in PLPMTUD… janaiyengar