Re: [quicwg/base-drafts] Define terms for application actions (#2857)
MikkelFJ <notifications@github.com> Fri, 18 October 2019 06:14 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 906411200CC for <quic-issues@ietfa.amsl.com>; Thu, 17 Oct 2019 23:14:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2ztHtVfpL4Ll for <quic-issues@ietfa.amsl.com>; Thu, 17 Oct 2019 23:13:57 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9D77E120045 for <quic-issues@ietf.org>; Thu, 17 Oct 2019 23:13:57 -0700 (PDT)
Date: Thu, 17 Oct 2019 23:13:56 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571379236; bh=0g7i/5X76+gD/Zq8XrGoGjxoQImabb15BF4ADSbqs7M=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=CtxSuBWNPJi2bF76DZg6jZqz2L4wFADq1fpd5TT4P7oNcSeARhNRiAZ+mU5bQ2p9N 1l4qyjy+D1lNdbb49AgLbsJ4c5f8p8T//K4IS2liYSc+HAaGSt1udFbx2ceOEZDJhL 5Vi96Qj0TrPHVYfyAnrEbMJBG7Bm+F+24CcYxs9g=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK55S2QSPQBDDTCC3Y53W2MLJEVBNHHBXBSRPY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2857/review/303679855@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2857@github.com>
References: <quicwg/base-drafts/pull/2857@github.com>
Subject: Re: [quicwg/base-drafts] Define terms for application actions (#2857)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da95824ac660_633c3fd6432cd96411062"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/C2dQ3zBWmb1-fJvLz1Izf1RM96k>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Oct 2019 06:14:01 -0000
mikkelfj commented on this pull request. I realize this is merged by now, but I still have a few comments. > +## Required Operations on Streams + +There are certain operations which an application MUST be able to perform when +interacting with QUIC streams. This document does not specify an API, but +any implementation of this version of QUIC MUST expose the ability to perform +the operations described in this section on a QUIC stream. + +On the sending part of a stream, application protocols need to be able to: + +- write data, understanding when stream flow control credit + ({{data-flow-control}}) has successfully been reserved to send the written + data +- end the stream (clean termination), resulting in a STREAM frame + ({{frame-stream}}) with the FIN bit set; and +- reset the stream (abrupt termination), resulting in a RESET_STREAM frame + ({{frame-reset-stream}}), even if the stream was already ended. This is unclear - what does it mean that "the stream was already ended"? I would say it is fair for an API to issue a soft error if you try to RESET (abrupt termination) after having issued a FIN request (clean termination), or vice version. Certainly I would not want a QUIC implementation tracking a stream handle indefinitely in case some app decides to reset it eventually. > @@ -1101,6 +1132,41 @@ suggested structure: --> +## Required Operations on Connections + +There are certain operations which an application MUST be able to perform when +interacting with the QUIC transport. This document does not specify an API, but +any implementation of this version of QUIC MUST expose the ability to perform +the operations described in this section on a QUIC connection. + +When implementing the client role, applications need to be able to: + +- open a connection, which begins the exchange described in {{handshake}}; +- enable 0-RTT; and +- be informed when 0-RTT has been accepted or rejected by a server. But why does an application need to be able to enable 0-RTT? Isn't 0-RTT optional at transport level, and more so at the app level? > + +When implementing the client role, applications need to be able to: + +- open a connection, which begins the exchange described in {{handshake}}; +- enable 0-RTT; and +- be informed when 0-RTT has been accepted or rejected by a server. + +When implementing the server role, applications need to be able to: + +- listen for incoming connections, which prepares for the exchange described in + {{handshake}}; +- if Early Data is supported, embed application-controlled data in the TLS + resumption ticket sent to the client; and +- if Early Data is supported, retrieve application-controlled data from the + client's resumption ticket and enable rejecting Early Data based on that + information. An app should also be able to reject incoming connections, for example based on implementation specific criteria such as load or peer IP address. > + +- listen for incoming connections, which prepares for the exchange described in + {{handshake}}; +- if Early Data is supported, embed application-controlled data in the TLS + resumption ticket sent to the client; and +- if Early Data is supported, retrieve application-controlled data from the + client's resumption ticket and enable rejecting Early Data based on that + information. + +In either role, applications need to be able to: + +- configure minimum values for the initial number of permitted streams of each + type, as communicated in the transport parameters ({{transport-parameters}}); +- control resource allocation of various types, including flow control and the + number of permitted streams of each type; +- identify whether the handshake has completed successfully or is still ongoing Given that hanshake keys must now be held forever, how can it be indicated that a handshake is complete? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2857#pullrequestreview-303679855
- [quicwg/base-drafts] Define terms for application… Mike Bishop
- Re: [quicwg/base-drafts] Define terms for applica… Mike Bishop
- Re: [quicwg/base-drafts] Define terms for applica… Mike Bishop
- Re: [quicwg/base-drafts] Define terms for applica… Mike Bishop
- Re: [quicwg/base-drafts] Define terms for applica… Martin Thomson
- Re: [quicwg/base-drafts] Define terms for applica… MikkelFJ
- Re: [quicwg/base-drafts] Define terms for applica… Mike Bishop
- Re: [quicwg/base-drafts] Define terms for applica… Mike Bishop
- Re: [quicwg/base-drafts] Define terms for applica… Mike Bishop
- Re: [quicwg/base-drafts] Define terms for applica… Mike Bishop
- Re: [quicwg/base-drafts] Define terms for applica… Lucas Pardue
- Re: [quicwg/base-drafts] Define terms for applica… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Define terms for applica… ianswett
- Re: [quicwg/base-drafts] Define terms for applica… Mike Bishop
- Re: [quicwg/base-drafts] Define terms for applica… Mike Bishop
- Re: [quicwg/base-drafts] Define terms for applica… Mike Bishop
- Re: [quicwg/base-drafts] Define terms for applica… Mike Bishop
- Re: [quicwg/base-drafts] Define terms for applica… Mike Bishop
- Re: [quicwg/base-drafts] Define terms for applica… Martin Thomson
- Re: [quicwg/base-drafts] Define terms for applica… ianswett
- Re: [quicwg/base-drafts] Define terms for applica… ianswett
- Re: [quicwg/base-drafts] Define terms for applica… ianswett
- Re: [quicwg/base-drafts] Define terms for applica… ianswett
- Re: [quicwg/base-drafts] Define terms for applica… Mike Bishop
- Re: [quicwg/base-drafts] Define terms for applica… Martin Thomson
- Re: [quicwg/base-drafts] Define terms for applica… MikkelFJ
- Re: [quicwg/base-drafts] Define terms for applica… Mike Bishop
- Re: [quicwg/base-drafts] Define terms for applica… Mike Bishop
- Re: [quicwg/base-drafts] Define terms for applica… Mike Bishop
- Re: [quicwg/base-drafts] Define terms for applica… Mike Bishop
- Re: [quicwg/base-drafts] Define terms for applica… MikkelFJ
- Re: [quicwg/base-drafts] Define terms for applica… MikkelFJ
- Re: [quicwg/base-drafts] Define terms for applica… MikkelFJ
- Re: [quicwg/base-drafts] Define terms for applica… Mike Bishop