Re: [quicwg/base-drafts] use max_ack_delay = 0 before receving the TPs (#2646)

[ianswett <[e-mail]>]

ianswett approved this pull request.

One small suggestion, but LG.

> @@ -1028,9 +1029,9 @@ min_rtt:
 
 max_ack_delay:
 : The maximum amount of time by which the receiver intends to delay
-  acknowledgments, in milliseconds.  The actual ack_delay in a
-  received ACK frame may be larger due to late timers, reordering,
-  or lost ACKs.
+  acknowledgments. The value is initialized to 0, and updated when the peer's
+  transport parameters are received. The actual ACK Delay in a received ACK
+  frame may be larger due to late timers, reordering, or lost ACKs.

Instead of crypto packets, I'd suggest packets in the ApplicationData packet number space?

> @@ -1111,7 +1111,10 @@ OnAckReceived(ack, pn_space):
       IncludesAckEliciting(newly_acked_packets))
     latest_rtt =
       now - sent_packets[pn_space][ack.largest_acked].time_sent
-    UpdateRtt(ack.ack_delay)
+    ack_delay = 0
+    if pn_space == 1-RTT:

```suggestion
    if pn_space == ApplicationData:
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2646#pullrequestreview-231878002