Re: [quicwg/base-drafts] use max_ack_delay = 0 before receving the TPs (#2646)

ianswett <notifications@github.com> Mon, 29 April 2019 20:16 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 755D612075C for <quic-issues@ietfa.amsl.com>; Mon, 29 Apr 2019 13:16:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3
X-Spam-Level:
X-Spam-Status: No, score=-3 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VYbYxItOlnYi for <quic-issues@ietfa.amsl.com>; Mon, 29 Apr 2019 13:16:33 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 63B3E1206B6 for <quic-issues@ietf.org>; Mon, 29 Apr 2019 13:16:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=jVdc0plL0Vw5CeJwhJJNrtRuI5Q=; b=qxYIN58jhgpTeDQY RGOu734MUK1PpOWdvhRCzTX7e3L8GX5LxqmHdjHaQVQAARJsVzZH53r1EP0R53xZ Ibvxr0Crhw/2u0UP9lRYUEaMHVdSqtGoIL8T0w+gpYDH6ye22fuqR+NEvV1IoFBO VsaLD/COGMM5BuSwA8c9hRHcZrk=
Received: by filter1739p1mdw1.sendgrid.net with SMTP id filter1739p1mdw1-22235-5CC75B9E-6 2019-04-29 20:16:30.095657883 +0000 UTC m=+339583.184666851
Received: from github-lowworker-cef7735.cp1-iad.github.net (unknown [140.82.115.2]) by ismtpd0038p1iad2.sendgrid.net (SG) with ESMTP id qwC2EuJCRIStDgYRrajpIA for <quic-issues@ietf.org>; Mon, 29 Apr 2019 20:16:30.200 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-cef7735.cp1-iad.github.net (Postfix) with ESMTP id 1C5AB1E035B for <quic-issues@ietf.org>; Mon, 29 Apr 2019 13:16:30 -0700 (PDT)
Date: Mon, 29 Apr 2019 20:16:30 +0000 (UTC)
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5DKXBI6VEZDANSIXF22SHB5EVBNHHBUA7M3M@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2646/review/231878002@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2646@github.com>
References: <quicwg/base-drafts/pull/2646@github.com>
Subject: Re: [quicwg/base-drafts] use max_ack_delay = 0 before receving the TPs (#2646)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cc75b9e1aa57_7073fdd3dccd968516165"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3vLIOFwSt/lx3eQ1RSl+1nHx5ZDPFOJroWb8 nXyeAXeLFtlaTwkDF3XX8KrdaTgb9Lva8ehNkUdA4BcL8BFBl7jlE0+dDqjNPUFgfYiB1de2dM9YfT 19zX4dWekUtE/wuHDMXtAXyq4UV/a/I8nN0Wb+RJVCKFx2nUvXEeqMLq8g==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/C9dcHIr4uYRbx6MdU15DHa48oQo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Apr 2019 20:16:35 -0000

ianswett approved this pull request.

One small suggestion, but LG.

> @@ -1028,9 +1029,9 @@ min_rtt:
 
 max_ack_delay:
 : The maximum amount of time by which the receiver intends to delay
-  acknowledgments, in milliseconds.  The actual ack_delay in a
-  received ACK frame may be larger due to late timers, reordering,
-  or lost ACKs.
+  acknowledgments. The value is initialized to 0, and updated when the peer's
+  transport parameters are received. The actual ACK Delay in a received ACK
+  frame may be larger due to late timers, reordering, or lost ACKs.

Instead of crypto packets, I'd suggest packets in the ApplicationData packet number space?

> @@ -1111,7 +1111,10 @@ OnAckReceived(ack, pn_space):
       IncludesAckEliciting(newly_acked_packets))
     latest_rtt =
       now - sent_packets[pn_space][ack.largest_acked].time_sent
-    UpdateRtt(ack.ack_delay)
+    ack_delay = 0
+    if pn_space == 1-RTT:

```suggestion
    if pn_space == ApplicationData:
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2646#pullrequestreview-231878002