Re: [quicwg/base-drafts] Add initial threat model appendix (#2925)

Eric Kinnear <notifications@github.com> Wed, 04 September 2019 01:22 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0B17D12004A for <quic-issues@ietfa.amsl.com>; Tue, 3 Sep 2019 18:22:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WccmmVl6zbuO for <quic-issues@ietfa.amsl.com>; Tue, 3 Sep 2019 18:22:11 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9C590120098 for <quic-issues@ietf.org>; Tue, 3 Sep 2019 18:22:11 -0700 (PDT)
Date: Tue, 03 Sep 2019 18:22:10 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1567560130; bh=dlb+3VPMgWPN22iB2o+hV030bJ3RU6w3V6uHr2A24Js=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=UhP+I9MdbcUyjTXJyT4EgXYJZcveKX5LNJ159Db1lC75uH//zTek6l8/jHvNV1D9R 0GZB50BwpFw2kvjEELDyZVrZgX75JSm0rJIM0xnUgAMAlyOv/b17EDygzwy45GZGZH nD9uiRI9fC0bp6anMbM87hQD8p7qbkPasFE8R+MA=
From: Eric Kinnear <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2LHF3X54A7IQFHSMV3PRJFFEVBNHHBYGSUE4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2925/review/283335625@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2925@github.com>
References: <quicwg/base-drafts/pull/2925@github.com>
Subject: Re: [quicwg/base-drafts] Add initial threat model appendix (#2925)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d6f11c2b60f3_4a1d3fcd89ecd95c124262"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: erickinnear
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/CKGRTCgmzMCNeFVqeyZRu5Dyojc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Sep 2019 01:22:14 -0000

erickinnear commented on this pull request.



> @@ -5753,13 +5753,184 @@ DecodePacketNumber(largest_pn, truncated_pn, pn_nbits):
    return candidate_pn
 ~~~
 
+# Overview of Security Properties {#security-properties}

Two thoughts here: 
- This was an appendix since TLS 1.3 did it as an appendix. It's kind of nice that way, since we're documenting what we believe the rest of the document says, not introducing any new attacks or mitigations that shouldn't already have been covered above.
- From a purely aesthetic perspective, having 21.11.3.2. as a section means that I refer to one of these items as: 
> Section 21.11.3.2., point 3.

All that said, I've moved this to the last section in Security Considerations for the time being, and I don't have a super strong opinion on where it finally lands. :)
TLS is also a little bit different in that most of the document is a security consideration in one way or another, so some of the reasoning that resulted in structure there is not necessarily reflected in QUIC.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2925#discussion_r320538854