Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 72A2F1294D0
 for <quic-issues@ietfa.amsl.com>; Wed, 21 Nov 2018 10:38:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.459
X-Spam-Level: 
X-Spam-Status: No, score=-9.459 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001,
 HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5,
 SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id fEsqJ5pdG_oQ for <quic-issues@ietfa.amsl.com>;
 Wed, 21 Nov 2018 10:38:41 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id B342412426A
 for <quic-issues@ietf.org>; Wed, 21 Nov 2018 10:38:41 -0800 (PST)
Date: Wed, 21 Nov 2018 10:38:40 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
 s=pf2014; t=1542825520;
 bh=s1w2Dfcka/nySpMflfMtnHPa3XbzBZQ7IwYb15KcOdg=;
 h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
 List-Archive:List-Post:List-Unsubscribe:From;
 b=zgrjIlZydUP1hxAKK11InBLtDLLK/zlP1is640Cj00Y/8ou5pkgTWs+MfyCu4IhHu
 vimmRL/oLBXipkAhSxzZbiFv9X5vnVkW5JbnFFUQThe7+yHJLgAJUgvhQJWSK1IsUF
 LYoemhcvD70QFRlZ4IXsLjkU6l2NlgiPGqASzQlM=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab48e26979775adb3d53d47d6752bf1659a50cb90792cf00000001180d683092a169ce16d3ac5a@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2033/review/177381294@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2033@github.com>
References: <quicwg/base-drafts/pull/2033@github.com>
Subject: Re: [quicwg/base-drafts] Fix for off-path migration attack (#2033)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5bf5a630d27a2_2bb93f9dda4d45c436701e";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/CKhAc5L4KfjWB_Oh5tNDpCYIZd0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG
 <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Nov 2018 18:38:44 -0000


----==_mimepart_5bf5a630d27a2_2bb93f9dda4d45c436701e
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

MikeBishop commented on this pull request.

I agree it feels a bit verbose, but I think all the right information is there.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2033#pullrequestreview-177381294
----==_mimepart_5bf5a630d27a2_2bb93f9dda4d45c436701e
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@MikeBishop</b> commented on this pull request.</p>

<p>I agree it feels a bit verbose, but I think all the right information is there.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2033#pullrequestreview-177381294">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq-g3NkGsBx4JKHapSrlSDm4wozHEks5uxZ2wgaJpZM4YseFR">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq7HfAa9Ak8wuetZVjox-u0bACon8ks5uxZ2wgaJpZM4YseFR.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@MikeBishop commented on #2033"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/2033#pullrequestreview-177381294"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2033#pullrequestreview-177381294",
"url": "https://github.com/quicwg/base-drafts/pull/2033#pullrequestreview-177381294",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@MikeBishop commented on 2033",
"sections": [
{
"text": "I agree it feels a bit verbose, but I think all the right information is there.",
"activityTitle": "**Mike Bishop**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@MikeBishop",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/2033#pullrequestreview-177381294"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 414310737\n}"
}
],
"themeColor": "26292E"
}
]</script>
----==_mimepart_5bf5a630d27a2_2bb93f9dda4d45c436701e--

