[quicwg/base-drafts] 2ce00d: Improve language on evictable entries. (#3131)
Bence Béky <noreply@github.com> Tue, 25 February 2020 22:30 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2FA953A02BB for <quic-issues@ietfa.amsl.com>; Tue, 25 Feb 2020 14:30:58 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.1
X-Spam-Level:
X-Spam-Status: No, score=-2.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6MfxuTa5oGfR for <quic-issues@ietfa.amsl.com>; Tue, 25 Feb 2020 14:30:55 -0800 (PST)
Received: from out-9.smtp.github.com (out-9.smtp.github.com [192.30.254.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A696A3A0128 for <quic-issues@ietf.org>; Tue, 25 Feb 2020 14:30:55 -0800 (PST)
Date: Tue, 25 Feb 2020 14:30:54 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1582669855; bh=UPF4unv41NGOUGnuzS3qON56bkIeejdb2hy0bRrHwPQ=; h=Date:From:To:Subject:From; b=ota9E/yODJ9Jyf6wbTpm4SeSIgXorMvVizP3vdn6n0epjQJuvbZI+OMw7nfGHFzOL 7wsllJ3k4ePCA9n+s5bBDJAjoI5EHm5364qiq9J8ccXOEBXvzLPhy/2Rijh/HrCVFj 9T3ndrmq/Hc+Fnex1AE15/dFLne0xWhRpbr0C9jI=
From: Bence Béky <noreply@github.com>
To: quic-issues@ietf.org
Message-ID: <quicwg/base-drafts/push/refs/heads/master/96a640-2ce00d@github.com>
Subject: [quicwg/base-drafts] 2ce00d: Improve language on evictable entries. (#3131)
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-Auto-Response-Suppress: All
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/CTBxQcxBJMR8hVdSAEpLkIwVtFo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Feb 2020 22:30:58 -0000
Branch: refs/heads/master Home: https://github.com/quicwg/base-drafts Commit: 2ce00d0f25b338bbc3a917805fb06d477edfacc1 https://github.com/quicwg/base-drafts/commit/2ce00d0f25b338bbc3a917805fb06d477edfacc1 Author: Bence Béky <bencebeky@users.noreply.github.com> Date: 2020-02-25 (Tue, 25 Feb 2020) Changed paths: M draft-ietf-quic-qpack.md Log Message: ----------- Improve language on evictable entries. (#3131) * Improve language on blocking entries. Remove "insertion has been acknowledged" phrase to avoid confusion between Header Acknowledgement instructions implicitly acknowledging encoder stream instructions and explicitly acknowledging header blocks. Use Known Received Count instead. Clarify that references on the encoder stream do not block an entry from eviction. Trivial as it is, I overlooked this at first, and added quite some unnecessary complexity that was eventually removed at https://quiche.googlesource.com/quiche/+/b09d44167c543b80b2c27408dd1f9df3b07c9741. My motivation here is to help future implementers to avoid this pitfall. Merge redundant Reference Tracking section into Blocked Dynamic Table Insertions. Change style of "Note" at end of section for consistency. There were already four sentences starting with "Note that" throughout the draft before this PR (now there are six), but no other "Note:" markdown. * Revert changing acknowledging insertion to comparing absolute index to Known Received Count. * Remove unnecessary wordcrafting to blocked-insertion first paragraph. * wordsmithing * nit * Minor rewording