Re: [quicwg/base-drafts] ACK and PADDING (#1713)
Martin Thomson <notifications@github.com> Tue, 28 August 2018 22:49 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 11207130E0C for <quic-issues@ietfa.amsl.com>; Tue, 28 Aug 2018 15:49:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yJXvEH1caGTN for <quic-issues@ietfa.amsl.com>; Tue, 28 Aug 2018 15:49:27 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 49004130DDA for <quic-issues@ietf.org>; Tue, 28 Aug 2018 15:49:27 -0700 (PDT)
Date: Tue, 28 Aug 2018 15:49:26 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1535496566; bh=4Ca49dpB/9TxSfg+ThTp5wETcyX3jH+AWzSqg8N7jDA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=MofRgFvy8SxZbzrEEfmW3fV/+iF7g8/uZ7kA04ClAIw6ReMFn0MkUKKLkY58T3dt4 aAW+EN0MVEHvNw+sJyHOqQVW5qDN1RoZRSzNXB1fY4zQUkm4Wn2BRuEUehODDWjYl1 xw9tK1xoD9R4Riex+aezSlV2GIIdD05F15sE0MAg=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abcd3978a024ffb4f5ab030064c9bb6d5dfcdbfc0292cf00000001179d937692a169ce1527d0a4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1713/review/150346487@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1713@github.com>
References: <quicwg/base-drafts/pull/1713@github.com>
Subject: Re: [quicwg/base-drafts] ACK and PADDING (#1713)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b85d176747d3_d713fe834cd45b81596d2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/CTPFkGIcTZwLCAA6MQiL-JcGq4Q>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Aug 2018 22:49:29 -0000
martinthomson commented on this pull request. > @@ -3418,14 +3418,15 @@ ACK Block (repeated): ### Sending ACK Frames Implementations MUST NOT generate packets that only contain ACK frames in -response to packets which only contain ACK frames. However, they MUST -acknowledge packets containing only ACK frames when sending ACK frames in -response to other packets. Implementations MUST NOT send more than one packet -containing only an ACK frame per received packet that contains frames other than -an ACK frame. Packets containing non-ACK frames MUST be acknowledged -immediately or when a delayed ack timer expires. The delayed ack timer MUST -NOT delay an ACK for longer than an RTT, which ensures an ACK frame is sent -at least once per RTT if new packets needing acknowledgement were received. +response to packets which only contain ACK and PADDING frames. However, they +MUST acknowledge packets containing only ACK and PADDING frames when sending +ACK frames in response to other packets. Implementations MUST NOT send more +than one packet containing only an ACK frame per received packet that contains "containing only ACK or PADDING frames" ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1713#pullrequestreview-150346487
- [quicwg/base-drafts] ACK and PADDING (#1713) ianswett
- Re: [quicwg/base-drafts] ACK and PADDING (#1713) Martin Thomson
- Re: [quicwg/base-drafts] ACK and PADDING (#1713) Martin Thomson
- Re: [quicwg/base-drafts] ACK and PADDING (#1713) ianswett
- Re: [quicwg/base-drafts] ACK and PADDING (#1713) Martin Thomson
- Re: [quicwg/base-drafts] ACK and PADDING (#1713) Christian Huitema
- Re: [quicwg/base-drafts] ACK and PADDING (#1713) MikkelFJ
- Re: [quicwg/base-drafts] ACK and PADDING (#1713) ianswett
- Re: [quicwg/base-drafts] ACK and PADDING (#1713) Martin Thomson
- Re: [quicwg/base-drafts] ACK and PADDING (#1713) Martin Thomson