Re: [quicwg/base-drafts] HTTP/3 references QUIC Stream IDs directly, allowing illegal references (#3273)

Lucas Pardue <notifications@github.com> Thu, 05 December 2019 14:54 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 194D5120019 for <quic-issues@ietfa.amsl.com>; Thu, 5 Dec 2019 06:54:11 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.5
X-Spam-Level:
X-Spam-Status: No, score=-7.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, PDS_BTC_ID=0.499, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BjglUQqMlK7C for <quic-issues@ietfa.amsl.com>; Thu, 5 Dec 2019 06:54:09 -0800 (PST)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 40EAE120013 for <quic-issues@ietf.org>; Thu, 5 Dec 2019 06:54:09 -0800 (PST)
Received: from github-lowworker-45eca55.ac4-iad.github.net (github-lowworker-45eca55.ac4-iad.github.net [10.52.25.70]) by smtp.github.com (Postfix) with ESMTP id 3E139661EAA for <quic-issues@ietf.org>; Thu, 5 Dec 2019 06:54:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1575557648; bh=srVK7vfryMwEIkfdGVElsD5tn8bENmWqudgwaIMVJI0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=UswGAHA3FmEXJTGZS6NelertTUQO6DUkPHAAgpDemouKSNRltWV9Ds53O351clv6B 556uvYxdiWOjQkbGBIerf/h8FGvr7aea4ldPCPo5t2P61j8YUBUZ++pDDGkYyEYZXq LeSMQ87c421gUiC3Q6ugs9Gs1e/2G4EvSXzD7Ths=
Date: Thu, 05 Dec 2019 06:54:08 -0800
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYZLPQFK7PAQJK2Q2V36ZGJBEVBNHHB64UA7U@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3273/562163460@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3273@github.com>
References: <quicwg/base-drafts/issues/3273@github.com>
Subject: Re: [quicwg/base-drafts] HTTP/3 references QUIC Stream IDs directly, allowing illegal references (#3273)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5de91a102faf8_3be23fca198cd96c500f6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/CV8RvkbNA0hNIGR33uPNuayhrXk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Dec 2019 14:54:11 -0000

@ianswett 
> In this case, in order to ensure the GOAWAY doesn't reference an invalid Stream ID, you need to be able to query the type of a Stream ID even if the stream hasn't been created.

I don't see why this is a problem - the stream ID value indicates the type even if an instance of that stream does not exist in a connection. In fact, we rely on this when GOAWAY with MAX_CLIENT_INITIATED_BIDI is sent. 

@kazuho 
> One trivial example is the value of GOAWAY.stream_id when the server closes an HTTP/3 connection that has carried no request. In such case, it is my understanding that GOAWAY.stream_id should be zero. But how does the server determine that value?

Spec says: 

> This identifier MAY be zero if no requests were processed.

 I think MT's example is pretty straightforward way to account


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3273#issuecomment-562163460