Re: [quicwg/base-drafts] Stateless reset comparisons (constant time/any order/datagram) (#2993)
ekr <notifications@github.com> Wed, 16 October 2019 21:19 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 167A61201EF for <quic-issues@ietfa.amsl.com>; Wed, 16 Oct 2019 14:19:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GLQBKAXmnlgs for <quic-issues@ietfa.amsl.com>; Wed, 16 Oct 2019 14:19:25 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 239A012080C for <quic-issues@ietf.org>; Wed, 16 Oct 2019 14:19:25 -0700 (PDT)
Date: Wed, 16 Oct 2019 14:19:24 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571260764; bh=yRK7usWM/ILhxqWpifkuIgwXud0Ia9tpNhmmAtLwNHE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TKjc+J/kxL14V1OAM5myGu2wjF75Jjv/6pU2gFwpN/xWEzW9pgjPRWueo+lYTO5uj tPNA69zK2e02sr/fRKM/Hba+/SxULO0pHKxh7SUlutYZaAhpDK2UNtug9D+Pm/Fb5+ Eh3YFZbh2wzD8TROw3GC5JDOxuShdF+xPFnuG5AY=
From: ekr <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK56VMP4Y4YIKCEQ6NN3WTE6ZEVBNHHBZ4IYAM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2993/review/302883710@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2993@github.com>
References: <quicwg/base-drafts/pull/2993@github.com>
Subject: Re: [quicwg/base-drafts] Stateless reset comparisons (constant time/any order/datagram) (#2993)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da7895c4e28b_73f13faf610cd9601321aa"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ekr
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/CgeI4lCjSBqSQk4LD_Pj19YajAY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Oct 2019 21:19:27 -0000
ekr commented on this pull request. > -If the last 16 bytes of the packet values are identical to a Stateless Reset +An endpoint detects a potential stateless reset using the trailing 16 bytes of +the UDP datagram. An endpoint remembers all Stateless Reset Tokens associated +with the connection IDs and remote addresses for datagrams it has recently sent. +This includes Stateless Reset Tokens from NEW_CONNECTION_ID frames and the +server's transport parameters but excludes Stateless Reset Tokens associated +with connection IDs that are either unused or retired. The endpoint identifies +a received datagram as a stateless reset by comparing the last 16 bytes of the +datagram with all Stateless Reset Tokens associated with the remote address on +which the datagram was received. + +This comparison can be performed for every inbound datagram. Endpoints MAY skip +this check if any packet from a datagram is successfully processed. However, +the comparison MUST be performed when the first packet in an incoming datagram +either cannot be associated with a connection, cannot be decrypted, or carries +a duplicate packet number. I don't think I understand the rationale for this duplicate packet number check. If you have a valid packet, it seems like one ought to assume that it's not also a stateless reset or coalesced with one. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2993#pullrequestreview-302883710
- [quicwg/base-drafts] Perform stateless reset toke… Martin Thomson
- Re: [quicwg/base-drafts] Perform stateless reset … Martin Thomson
- Re: [quicwg/base-drafts] Perform stateless reset … Mike Bishop
- Re: [quicwg/base-drafts] Perform stateless reset … Jana Iyengar
- Re: [quicwg/base-drafts] Perform stateless reset … Jana Iyengar
- Re: [quicwg/base-drafts] Perform stateless reset … ianswett
- Re: [quicwg/base-drafts] Perform stateless reset … Martin Thomson
- Re: [quicwg/base-drafts] Perform stateless reset … Marten Seemann
- Re: [quicwg/base-drafts] Perform stateless reset … ianswett
- Re: [quicwg/base-drafts] Perform stateless reset … Martin Thomson
- Re: [quicwg/base-drafts] Perform stateless reset … Kazuho Oku
- Re: [quicwg/base-drafts] Perform stateless reset … Kazuho Oku
- Re: [quicwg/base-drafts] Perform stateless reset … Martin Thomson
- Re: [quicwg/base-drafts] Perform stateless reset … Kazuho Oku
- Re: [quicwg/base-drafts] Perform stateless reset … Marten Seemann
- Re: [quicwg/base-drafts] Perform stateless reset … Martin Thomson
- Re: [quicwg/base-drafts] Perform stateless reset … Martin Thomson
- Re: [quicwg/base-drafts] Perform stateless reset … Martin Thomson
- Re: [quicwg/base-drafts] Perform stateless reset … Martin Thomson
- Re: [quicwg/base-drafts] Perform stateless reset … Mike Bishop
- Re: [quicwg/base-drafts] Stateless reset comparis… Jana Iyengar
- Re: [quicwg/base-drafts] Stateless reset comparis… Jana Iyengar
- Re: [quicwg/base-drafts] Stateless reset comparis… Mike Bishop
- Re: [quicwg/base-drafts] Stateless reset comparis… Martin Thomson
- Re: [quicwg/base-drafts] Stateless reset comparis… Martin Thomson
- Re: [quicwg/base-drafts] Stateless reset comparis… ianswett
- Re: [quicwg/base-drafts] Stateless reset comparis… Martin Thomson
- Re: [quicwg/base-drafts] Stateless reset comparis… Jana Iyengar
- Re: [quicwg/base-drafts] Stateless reset comparis… Martin Thomson
- Re: [quicwg/base-drafts] Stateless reset comparis… Martin Thomson
- Re: [quicwg/base-drafts] Stateless reset comparis… ekr
- Re: [quicwg/base-drafts] Stateless reset comparis… Martin Thomson
- Re: [quicwg/base-drafts] Stateless reset comparis… Martin Thomson
- Re: [quicwg/base-drafts] Stateless reset comparis… Martin Thomson