Re: [quicwg/base-drafts] Additional error cases for CANCEL_PUSH (#3083)

ianswett <> Fri, 11 October 2019 21:35 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 4C814120819 for <>; Fri, 11 Oct 2019 14:35:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id uwteQk22kWOt for <>; Fri, 11 Oct 2019 14:35:19 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id C06F2120816 for <>; Fri, 11 Oct 2019 14:35:19 -0700 (PDT)
Received: from ( []) by (Postfix) with ESMTP id 009A466047A for <>; Fri, 11 Oct 2019 14:35:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1570829719; bh=M/F+3QJtrHeaZhcP0XtLzv7wVVMfHLpK8qTZVzT6qO0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=0pIrrK/p2o63xxvpLBzZCmuHl96RUmPR18mMPmTRHPbVDydXIOUb2mqDWrlaPzzz+ Z/qNnQgmdKc+42c5ZzbhjHT4CQ4+e8eLtf1aqflgYCNajCBlwZn1w3Bc6VtcKME/DK tWrK1+VpdSdp9bACnaTqWbuDmARW1v3uuz2w17Ik=
Date: Fri, 11 Oct 2019 14:35:18 -0700
From: ianswett <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/3083/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Additional error cases for CANCEL_PUSH (#3083)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da0f596e6167_20203fb70f0cd96457251"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Fri, 11 Oct 2019 21:35:32 -0000

ianswett approved this pull request.

> @@ -1093,10 +1094,15 @@ error of type HTTP_FRAME_UNEXPECTED.
 The CANCEL_PUSH frame carries a Push ID encoded as a variable-length integer.
 The Push ID identifies the server push that is being cancelled (see
+{{frame-push-promise}}).  If a CANCEL_PUSH frame is received which references a
+Push ID greater than currently allowed on the connection, this MUST be treated

SG, I think I'm ok with this then.  I still find this section a bit of a hard read, but I don't have any specific suggestions.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: