Re: [quicwg/base-drafts] Additional error cases for CANCEL_PUSH (#3083)

ianswett <notifications@github.com> Fri, 11 October 2019 21:35 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4C814120819 for <quic-issues@ietfa.amsl.com>; Fri, 11 Oct 2019 14:35:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uwteQk22kWOt for <quic-issues@ietfa.amsl.com>; Fri, 11 Oct 2019 14:35:19 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C06F2120816 for <quic-issues@ietf.org>; Fri, 11 Oct 2019 14:35:19 -0700 (PDT)
Received: from github-lowworker-19d82f6.ac4-iad.github.net (github-lowworker-19d82f6.ac4-iad.github.net [10.52.16.75]) by smtp.github.com (Postfix) with ESMTP id 009A466047A for <quic-issues@ietf.org>; Fri, 11 Oct 2019 14:35:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1570829719; bh=M/F+3QJtrHeaZhcP0XtLzv7wVVMfHLpK8qTZVzT6qO0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=0pIrrK/p2o63xxvpLBzZCmuHl96RUmPR18mMPmTRHPbVDydXIOUb2mqDWrlaPzzz+ Z/qNnQgmdKc+42c5ZzbhjHT4CQ4+e8eLtf1aqflgYCNajCBlwZn1w3Bc6VtcKME/DK tWrK1+VpdSdp9bACnaTqWbuDmARW1v3uuz2w17Ik=
Date: Fri, 11 Oct 2019 14:35:18 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2VFXDTRPQPN4FSXO53VY3CNEVBNHHB4DMTGA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3083/review/300938096@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3083@github.com>
References: <quicwg/base-drafts/pull/3083@github.com>
Subject: Re: [quicwg/base-drafts] Additional error cases for CANCEL_PUSH (#3083)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da0f596e6167_20203fb70f0cd96457251"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/CmIWqUW3jVNTA_fGcNdRwV2RWIE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Oct 2019 21:35:32 -0000

ianswett approved this pull request.



> @@ -1093,10 +1094,15 @@ error of type HTTP_FRAME_UNEXPECTED.
 
 The CANCEL_PUSH frame carries a Push ID encoded as a variable-length integer.
 The Push ID identifies the server push that is being cancelled (see
-{{frame-push-promise}}).
+{{frame-push-promise}}).  If a CANCEL_PUSH frame is received which references a
+Push ID greater than currently allowed on the connection, this MUST be treated

SG, I think I'm ok with this then.  I still find this section a bit of a hard read, but I don't have any specific suggestions.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3083#pullrequestreview-300938096