Re: [quicwg/base-drafts] Rework Key Update (#2237)
Martin Thomson <notifications@github.com> Fri, 21 December 2018 05:56 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4874612E043 for <quic-issues@ietfa.amsl.com>; Thu, 20 Dec 2018 21:56:58 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.064
X-Spam-Level:
X-Spam-Status: No, score=-8.064 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tFJs_VUATLel for <quic-issues@ietfa.amsl.com>; Thu, 20 Dec 2018 21:56:56 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8F3F212D4E6 for <quic-issues@ietf.org>; Thu, 20 Dec 2018 21:56:56 -0800 (PST)
Date: Thu, 20 Dec 2018 21:56:55 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545371815; bh=EHb75kO8J9yBBwzn5HVbZhIXk9HemM8mPoJsqLJQZ7c=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=o8VliIOqIhjRAosy/wpI16Mb5onuOwn96QuGWLJ8HV0Jk2zeFkekmDqyyTOQbJIXz hz1AkiYFHrhoIkBXp0Y9SR0V5K9x52ROuzkr0GeIJL9AlCJx+nmLY1m63yXs0cspsJ AgZopiTH5fzr/kOrkFBQhM+dTzMzOWyLIHALrnKk=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3ddb4bdfcabfc27f9eb12ec6430b01526b546b1a92cf00000001183442a792a169ce1770e975@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2237/review/187279311@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2237@github.com>
References: <quicwg/base-drafts/pull/2237@github.com>
Subject: Re: [quicwg/base-drafts] Rework Key Update (#2237)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1c80a79ae58_499f3f9aa52d45b81292a3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/CuCNcUsdwmBADcalISjScAyZuws>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Dec 2018 05:56:58 -0000
martinthomson commented on this pull request. > + +Endpoints maintain separate read and write secrets for packet protection. An +endpoint initiates a key update by updating its packet protection write secret +and using that to protect new packets. The endpoint creates a new write secret +from the existing write secret as performed in Section 7.2 of {{!TLS13}}. This +uses the KDF function provided by TLS with a label of "quic ku". The +corresponding key and IV are created from that secret as defined in +{{protection-keys}}. The header protection key is not updated. + +The endpoint uses the key and IV to protect all subsequent packets, and inverts +the value of the KEY_PHASE bit to signal the change of keys. + +An endpoint MUST NOT initiate more than one key update at a time. A new key +cannot be used until the endpoint has received an acknowledgment for a packet it +sends with the new keys. An endpoint that receives a packet protected with old +keys that includes an acknowledgement for a packet protected with newer keys MAY No, the point of this is that you requested a key update and the peer didn't comply. This is how we ensure that endpoints update when requested. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2237#discussion_r243493730
- [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) ekr
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Marten Seemann
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Marten Seemann
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Marten Seemann
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Kazuho Oku
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Marten Seemann
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Kazuho Oku
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Kazuho Oku
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Marten Seemann
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Kazuho Oku
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Marten Seemann
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Kazuho Oku
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Kazuho Oku
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Marten Seemann
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Kazuho Oku
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Kazuho Oku
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Kazuho Oku
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Marten Seemann
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) hardie
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Nick Banks
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Kazuho Oku
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Kazuho Oku
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Kazuho Oku
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Jana Iyengar
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Kazuho Oku
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Christian Huitema
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Nick Banks
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Nick Banks
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Nick Banks
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Mike Bishop
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Mike Bishop
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Christian Huitema
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Jana Iyengar
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Mike Bishop
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) martinduke
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) martinduke
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson
- Re: [quicwg/base-drafts] Rework Key Update (#2237) Martin Thomson