Re: [quicwg/base-drafts] Simplify UpdateRtt pseudocode (#2610)

Marten Seemann <notifications@github.com> Fri, 12 April 2019 08:40 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9851512007A for <quic-issues@ietfa.amsl.com>; Fri, 12 Apr 2019 01:40:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.383
X-Spam-Level:
X-Spam-Status: No, score=-1.383 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uZp3uTBGlDDQ for <quic-issues@ietfa.amsl.com>; Fri, 12 Apr 2019 01:40:26 -0700 (PDT)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6005312001E for <quic-issues@ietf.org>; Fri, 12 Apr 2019 01:40:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=OMYGTES4k0SFiPY8vHstRUyYxOM=; b=X1cgir35+Cu3ezTX 5oxzRxuGshAuqe5acdTy8+j1gxWNfDUYPsOPKwWAbmb/wfksxRV+aLZg42grZLeA iHFcPT3d5hHxWRACzUsR9loY0gSUL0UpuGfLyCkH6srx062j11CrPfZQm2aHoEoO UEL7qGbimNNOTw3mzn+tJVM3oak=
Received: by filter1210p1las1.sendgrid.net with SMTP id filter1210p1las1-21618-5CB04EF7-2A 2019-04-12 08:40:23.947510539 +0000 UTC m=+287802.269922255
Received: from github-lowworker-1f7e42f.cp1-iad.github.net (unknown [192.30.252.46]) by ismtpd0001p1iad2.sendgrid.net (SG) with ESMTP id TIfCELSLTaaPotel6PDxkA for <quic-issues@ietf.org>; Fri, 12 Apr 2019 08:40:24.152 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-1f7e42f.cp1-iad.github.net (Postfix) with ESMTP id F2D23C056B for <quic-issues@ietf.org>; Fri, 12 Apr 2019 01:40:23 -0700 (PDT)
Date: Fri, 12 Apr 2019 08:40:24 +0000
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2e7dd02b5e2a6276fbf1332dfaca279c284fc99792cebabd817792a169ce19c5c948@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2610/review/225960387@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2610@github.com>
References: <quicwg/base-drafts/pull/2610@github.com>
Subject: Re: [quicwg/base-drafts] Simplify UpdateRtt pseudocode (#2610)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cb04ef7f0bc0_2cc13f94b80d45bc17619e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak12Orjou98f4+3+xJ0MCNZ/ExRECLnKpLzEon nL9vTivnXPuG30gaxObKgs32el3OYZUCaqGT3U7SkYI7OXzcX7Tw4It/LcFOcSdVjjPCgUn20EOaaA OC3tnx7vP6iKyJkFkaA/ZqeYEFbG/KdtsC4ql6dqvMNne7MAYmCjWp7OBQhFxgrQjPlPSr9bIq3VOk Y=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/CwHnlKDhhfpTaY6dh4335KqODYk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Apr 2019 08:40:28 -0000

marten-seemann commented on this pull request.



> @@ -1101,22 +1101,24 @@ OnAckReceived(ack, pn_space):
 
 
 UpdateRtt(latest_rtt, ack_delay):

It's used in `DetectLostPackets`, so it needs to be global.
To avoid confusion with scoping rules, the function parameter should have a different name than the global variable though.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2610#discussion_r274812476