Date: Fri, 12 Apr 2019 08:40:24 +0000 (UTC)
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab2e7dd02b5e2a6276fbf1332dfaca279c284fc99792cebabd817792a169ce19c5c948@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2610/review/225960387@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2610@github.com>
References: <quicwg/base-drafts/pull/2610@github.com>
Subject: Re: [quicwg/base-drafts] Simplify UpdateRtt pseudocode (#2610)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5cb04ef7f0bc0_2cc13f94b80d45bc17619e";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/CwHnlKDhhfpTaY6dh4335KqODYk>

----==_mimepart_5cb04ef7f0bc0_2cc13f94b80d45bc17619e
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

marten-seemann commented on this pull request.



> @@ -1101,22 +1101,24 @@ OnAckReceived(ack, pn_space):
 
 
 UpdateRtt(latest_rtt, ack_delay):

It's used in `DetectLostPackets`, so it needs to be global.
To avoid confusion with scoping rules, the function parameter should have a different name than the global variable though.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2610#discussion_r274812476
----==_mimepart_5cb04ef7f0bc0_2cc13f94b80d45bc17619e
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@marten-seemann</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2610#discussion_r274812476">draft-ietf-quic-recovery.md</a>:</p>
<pre style='color:#555'>&gt; @@ -1101,22 +1101,24 @@ OnAckReceived(ack, pn_space):
 
 
 UpdateRtt(latest_rtt, ack_delay):
</pre>
<p>It's used in <code>DetectLostPackets</code>, so it needs to be global.<br>
To avoid confusion with scoping rules, the function parameter should have a different name than the global variable though.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2610#discussion_r274812476">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq36UWeMWBc0DGfIZjZszi2Iuo2Anks5vgEZ3gaJpZM4crWeN">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq2qbwGBVkNHblI4ByeZNFV2hsMnaks5vgEZ3gaJpZM4crWeN.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@marten-seemann commented on #2610"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/2610#discussion_r274812476"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2610#discussion_r274812476",
"url": "https://github.com/quicwg/base-drafts/pull/2610#discussion_r274812476",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5cb04ef7f0bc0_2cc13f94b80d45bc17619e--