[quicwg/base-drafts] Only Update max_ack_delay for Retransmittable Packets (#1531)

Nick Banks <notifications@github.com> Fri, 06 July 2018 18:11 UTC

Date: Fri, 06 Jul 2018 11:11:55 -0700
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe870e1d450c2d77a3b1d5f0b3cadcfb7a9d582ad92cf00000001175772eb92a169ce14352c88@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1531@github.com>
Subject: [quicwg/base-drafts] Only Update max_ack_delay for Retransmittable Packets (#1531)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b3fb0eb7356_3d2b3fe054e68f8815122c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/D0NkG_w1nf7-2UD3UQPbT6mNKDE>

I came across this pseudocode while debugging an issue in my implementation related to it:

```
  UpdateRtt(latest_rtt, ack_delay):
    // min_rtt ignores ack delay.
    min_rtt = min(min_rtt, latest_rtt)
    // Adjust for ack delay if it's plausible.
    if (latest_rtt - min_rtt > ack_delay):
      latest_rtt -= ack_delay
      // Only save into max ack delay if it's used
      // for rtt calculation and is not ack only.
      if (!sent_packets[ack.largest_acked].ack_only)
        max_ack_delay = max(max_ack_delay, ack_delay)
```

Should this be ignoring all packets that don't contain any rentrasmittable frames, instead of just `ack_only` packets?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1531

[quicwg/base-drafts] Only Update max_ack_delay fo… Nick Banks
Re: [quicwg/base-drafts] Only Update max_ack_dela… Martin Thomson
Re: [quicwg/base-drafts] Only Update max_ack_dela… ianswett
Re: [quicwg/base-drafts] Only Update max_ack_dela… ianswett
Re: [quicwg/base-drafts] Only Update max_ack_dela… janaiyengar