Date: Fri, 20 Jul 2018 12:06:46 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab4e6b1973e7dff109e1589d881b7ec2ea4647f78992cf000000011769f4c692a169ce1474a4c7@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1592/406699167@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1592@github.com>
References: <quicwg/base-drafts/issues/1592@github.com>
Subject: Re: [quicwg/base-drafts] Single Stream of Bytes for CRYPTO Frames
 (#1592)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5b5232c66c7db_67f33fb1102be6241109ee";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/D2egwwsAyjgLBpuSyguFe6lK46Q>


----==_mimepart_5b5232c66c7db_67f33fb1102be6241109ee
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

I have the single stream approach implemented today, and it's ugly on the send side, because I need a very weird datastructure to determine what was sent at what encryption level and make sure there's no cross-encryption level bundling/etc.

With a stream per level, it's much clearer what's going on, and I can re-use most of the standard stream code.  I need to actually implement this, so maybe there are some issues I'm not anticipating, but I know the single stream approach is ugly.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1592#issuecomment-406699167
----==_mimepart_5b5232c66c7db_67f33fb1102be6241109ee
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p>I have the single stream approach implemented today, and it's ugly on =
the send side, because I need a very weird datastructure to determine wha=
t was sent at what encryption level and make sure there's no cross-encryp=
tion level bundling/etc.</p>
<p>With a stream per level, it's much clearer what's going on, and I can =
re-use most of the standard stream code.  I need to actually implement th=
is, so maybe there are some issues I'm not anticipating, but I know the s=
ingle stream approach is ugly.</p>

<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/issues/1592#issuecomment-406699167">view it on GitHub</a>,=
 or <a href=3D"https://github.com/notifications/unsubscribe-auth/AWbkq4hQ=
mNdcUqpUf0yDS7nMg3-TIpsPks5uIipGgaJpZM4VYkas">mute the thread</a>.<img sr=
c=3D"https://github.com/notifications/beacon/AWbkq3WOS9wLIEDQiS-YXtcw4F2b=
mBZJks5uIipGgaJpZM4VYkas.gif" height=3D"1" width=3D"1" alt=3D"" /></p>
<script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_versio=
n":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name"=
:"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"=
quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"http=
s://assets-cdn.github.com/images/email/message_cards/header.png","avatar_=
image_url":"https://assets-cdn.github.com/images/email/message_cards/avat=
ar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicw=
g/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ians=
wett in #1592: I have the single stream approach implemented today, and i=
t's ugly on the send side, because I need a very weird datastructure to d=
etermine what was sent at what encryption level and make sure there's no =
cross-encryption level bundling/etc.\r\n\r\nWith a stream per level, it's=
 much clearer what's going on, and I can re-use most of the standard stre=
am code.  I need to actually implement this, so maybe there are some issu=
es I'm not anticipating, but I know the single stream approach is ugly."}=
],"action":{"name":"View Issue","url":"https://github.com/quicwg/base-dra=
fts/issues/1592#issuecomment-406699167"}}}</script>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/issues/1592#issuecomment=
-406699167",
"url": "https://github.com/quicwg/base-drafts/issues/1592#issuecomment-40=
6699167",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [quicwg/base-drafts] Single Stream of Bytes for CRYPTO Fram=
es (#1592)",
"sections": [
{
"text": "",
"activityTitle": "**ianswett**",
"activityImage": "https://assets-cdn.github.com/images/email/message_card=
s/avatar.png",
"activitySubtitle": "@ianswett",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \=
"quicwg/base-drafts\",\n\"issueId\": 1592,\n\"IssueComment\": \"{{IssueCo=
mment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"q=
uicwg/base-drafts\",\n\"issueId\": 1592\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/issues/1592#issuecomment-40=
6699167"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 3587621=
56\n}"
}
],
"themeColor": "26292E"
}
]</script>=

----==_mimepart_5b5232c66c7db_67f33fb1102be6241109ee--