IETF Logo Mail Archive

Re: [quicwg/base-drafts] Explicitly suggest FIN or RST_STREAM (#1893)

Kazuho Oku <notifications@github.com> Fri, 19 October 2018 23:53 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A1E461310AF for <quic-issues@ietfa.amsl.com>; Fri, 19 Oct 2018 16:53:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.064
X-Spam-Level:
X-Spam-Status: No, score=-8.064 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.064, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k0dI6zvDG_Ns for <quic-issues@ietfa.amsl.com>; Fri, 19 Oct 2018 16:53:15 -0700 (PDT)
Received: from out-12.smtp.github.com (out-12.smtp.github.com [192.30.254.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C36E9130E17 for <quic-issues@ietf.org>; Fri, 19 Oct 2018 16:53:15 -0700 (PDT)
Date: Fri, 19 Oct 2018 16:53:14 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1539993195; bh=cJbNBJ+VaoMbx7HhdT1Uz11ttWRwEOz5cWw88i3xKME=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=MMi0iquroOP3QGJiWxsxrHrJm+XR6G7s73iRd6gi2JNrxHutIIWge01nOtr8SP7YV dOQb1VD8AlvqgWCDTCV6TVqKrixOzJQPS46TtsZzFiF7IqUKjEn+l7EbAmxsnQlAbT W6gjmDpyVAi/p4NzPueQdPZ4suH612K/zpERG/5Q=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abedfe6a92cfe542b0b7b65c21e5369f8f8e2ee27292cf0000000117e2306a92a169ce162d02a4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1893/c431529441@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1893@github.com>
References: <quicwg/base-drafts/pull/1893@github.com>
Subject: Re: [quicwg/base-drafts] Explicitly suggest FIN or RST_STREAM (#1893)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bca6e6aaa437_7a803fb22c4d45b85703d1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/D9hQvvObOgcuvHoLCoY2eGv3-0c>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Oct 2018 23:53:18 -0000

I agree with @RyanAtGoogle that the proposed text (quoted below) is confusing.
> It will often be the case that upon receipt of a RST_STREAM on a bidirectional stream, an endpoint will choose to stop sending data to the peer on that stream. If so, it SHOULD send a FIN or RST_STREAM for that stream to close the peer's receive stream state.

My view is that the text can be interpreted as allowing an endpoint to stop sending data on that stream without sending FIN or RST_STREAM.

I think that it would be beneficial to either avoid use of SHOULD (by for example replacing it to "needs to"), or change it to MUST.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1893#issuecomment-431529441

v2.37.1 | Report a Bug | By Email | System Status