IETF Logo Mail Archive

Re: [quicwg/base-drafts] Indicate initial-only frames (#2425)

Lucas Pardue <notifications@github.com> Wed, 06 February 2019 00:15 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 12FB6128D0C for <quic-issues@ietfa.amsl.com>; Tue, 5 Feb 2019 16:15:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.935
X-Spam-Level:
X-Spam-Status: No, score=-10.935 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Csdh_6xedBuB for <quic-issues@ietfa.amsl.com>; Tue, 5 Feb 2019 16:15:12 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6CE4312870E for <quic-issues@ietf.org>; Tue, 5 Feb 2019 16:15:12 -0800 (PST)
Date: Tue, 05 Feb 2019 16:15:11 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549412111; bh=87JUepZgkq88qjG/RKpG/suxeWOMYxsSwRgU4ArCyHA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=bODJ3w+gVaBa9GETCV/Uzjv3c79yy+wvwgQK+0v91bhsmmAyElAqMxxYUL7pwOSFJ mem2ztzEol9QLa0LYB0C51DM0PSQAZVQCSQ+u9YfF+avNHCaxmhotCzO6BzPO+JfWj A2ypRINERgV+SwIaZAtfxdllbGIkDVU3ta2j8bQY=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab655b2f9763bbe5836f404bf911f54a614af2201692cf000000011871e90f92a169ce1842c6e8@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2425/review/200367255@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2425@github.com>
References: <quicwg/base-drafts/pull/2425@github.com>
Subject: Re: [quicwg/base-drafts] Indicate initial-only frames (#2425)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5a270fb9433_6f523faa69ed45c4119391"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/DBZJrwdhwiLpih1Mh1RDPsbAarc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Feb 2019 00:15:14 -0000

LPardue approved this pull request.

Lgtm. 

An minor Improvement might be to highlight in the new sentence that "specific guidance is provided in the relevant section" but that might be obvious. I'm happy without anything further.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2425#pullrequestreview-200367255

v2.23.0 | Report a Bug | By Email