Re: [quicwg/base-drafts] Define preferred_address (#3807)

Mike Bishop <notifications@github.com> Wed, 01 July 2020 01:31 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3D8D33A089C for <quic-issues@ietfa.amsl.com>; Tue, 30 Jun 2020 18:31:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BWNIMpxS9Xc9 for <quic-issues@ietfa.amsl.com>; Tue, 30 Jun 2020 18:31:08 -0700 (PDT)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ACD733A089B for <quic-issues@ietf.org>; Tue, 30 Jun 2020 18:31:03 -0700 (PDT)
Received: from github-lowworker-c73936b.ash1-iad.github.net (github-lowworker-c73936b.ash1-iad.github.net [10.56.112.13]) by smtp.github.com (Postfix) with ESMTP id C50058C1777 for <quic-issues@ietf.org>; Tue, 30 Jun 2020 18:31:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1593567061; bh=SbOROkcSNYxWRYxyaFbQxpZFvYO3kuH8Xy4LZ3q0XdY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=slpjWww4h439Wgl2nCjoMuc4WIWwkTcOn6/0jQL+XuHBulpBPDaBjFluk5jTMM1eP 9XD02sba/yb+zV+n5HAeVkAIUbd8qELpIHpRDy6220DjeoqfLTKXo5MdTV2dr03xMc 6crakeTKUKa15sAlPJDQWiqRNqN50o3brkz+JybM=
Date: Tue, 30 Jun 2020 18:31:01 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZHZ2IPIUX3J5K63OF5A7EFLEVBNHHCNKET5Q@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3807/review/440489396@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3807@github.com>
References: <quicwg/base-drafts/pull/3807@github.com>
Subject: Re: [quicwg/base-drafts] Define preferred_address (#3807)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5efbe755b3411_1a433f84210cd96c971bc"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/DNzyfDxRXh213pDgCSemNDi5Y7g>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Jul 2020 01:31:10 -0000

@MikeBishop approved this pull request.



>    a preferred address of one address family by sending an all-zero address and
   port (0.0.0.0:0 or ::.0) for the other family. IP addresses are encoded in
   network byte order.
 
+: The preferred_address transport parameter contains an address and port for
+  both IP version 4 and 6.  The four-byte IPv4 Address field is followed by the
+  associated two-byte IPv4 Port field.  This is followed by a 16-byte IPv6
+  Address field and two-byte IPv6 Address field.  After address and port pairs,

```suggestion
  Address field and two-byte IPv6 Port field.  After address and port pairs,
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3807#pullrequestreview-440489396