[quicwg/base-drafts] Anti-amplification limits should count junk too (#3340)

Martin Thomson <notifications@github.com> Tue, 14 January 2020 11:50 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BCF66120052 for <quic-issues@ietfa.amsl.com>; Tue, 14 Jan 2020 03:50:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.454
X-Spam-Level:
X-Spam-Status: No, score=-6.454 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2TtLPT7XHfTv for <quic-issues@ietfa.amsl.com>; Tue, 14 Jan 2020 03:50:43 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DB7D4120045 for <quic-issues@ietf.org>; Tue, 14 Jan 2020 03:50:42 -0800 (PST)
Date: Tue, 14 Jan 2020 03:50:42 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579002642; bh=YA3/GpCOKLXg8oExO69xR6t6Vifg/3+CMNNHL/rNtag=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=MLbvOLL56IGNK72gWq2SNs+1JSt8wGtCWzuy4R8vWLSzUlRoEuJk8cQQYR3sVdOlI IO/tVSwFzZRDW5DwzBrCDduCnkRgu2FaSdzVK62g7u7+FoIfn8lZOh/ma2T8t/wiSy +Q2KjoJ8ARTEajDBcEBBbvCN6Uyt6PgZkxPVmj8g=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6TAP2CDC4X4ZCXA7N4FLOZFEVBNHHCBQHUUM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3340@github.com>
Subject: [quicwg/base-drafts] Anti-amplification limits should count junk too (#3340)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e1dab12ac24_477e3fd36bccd96c145188"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/DQmQa9p4Dgr-8_9RPhCoa23GPD0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jan 2020 11:50:46 -0000

>  In determining this limit, servers only count the size of successfully processed packets.

This is wrong.  If the server receives 0-RTT packets that it is discarding, it won't receive enough bytes to clear the 3x multiplier.  This needs to explicitly count all bytes received from the given address, even junk bytes.

I think that this is just editorial; this is just a mistake in transcription.  I'll defer to chairs.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3340