Re: [quicwg/base-drafts] Rearrange Packet Types section and references (#2203)

Mike Bishop <notifications@github.com> Wed, 19 December 2018 00:29 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EA465130ED1 for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 16:29:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.661
X-Spam-Level:
X-Spam-Status: No, score=-6.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YnE8-xt6H71E for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 16:29:42 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 119D3130DE4 for <quic-issues@ietf.org>; Tue, 18 Dec 2018 16:29:42 -0800 (PST)
Date: Tue, 18 Dec 2018 16:29:41 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545179381; bh=+5xV82+QNoyRCHnAyZYb1Tf2WxVtMxK55leCjNmDOes=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oBEGGoRmJc+RWwihfyVN26Y+X+lws6n2H65JiWffMbluddSS4FQL64Fu1Tq6XrpBJ aYCbRn5o8aviQsYuUPrjwCbMK2h7DakfNTnFW7CeHKtMFybCyM9RuGQLx06SCzRZou 3YqNdZVphNwB3dYPpP25v430kL9gFc5lAPxagWqk=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab6f05db3b56348d7d6760be06c9bb38d0e59d2a8792cf00000001183152f592a169ce175c9b40@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2203/review/186343895@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2203@github.com>
References: <quicwg/base-drafts/pull/2203@github.com>
Subject: Re: [quicwg/base-drafts] Rearrange Packet Types section and references (#2203)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1990f58909_26573fd4aacd45c421530"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/DQn5skDKDUj45Wy_nON5mJnUtlE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Dec 2018 00:29:44 -0000

MikeBishop commented on this pull request.



> @@ -2658,7 +2663,7 @@ level and can only be acknowledged in Handshake packets.
 
 This enforces cryptographic separation between the data sent in the different
 packet sequence number spaces.  Each packet number space starts at packet number
-0.  Subsequent packets sent in the same packet number space MUST increase the
+1.  Subsequent packets sent in the same packet number space MUST increase the

I think it's actually that it's `\d+\.` at the beginning of the line, and it's trying to normalize a numbered list.  I've considered trying to either insert or delete a word in that sentence, but....

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2203#discussion_r242755724