Re: [quicwg/base-drafts] Don't close the connection if MAX_STREAMS is too large (#2486)

[Mike Bishop <[e-mail]>]

MikeBishop requested changes on this pull request.

I don't know that this needs new 2119 language; can't we simply say that "When a MAX_STREAMS frame permits more streams than can be expressed by the stream ID (i.e. greater than 2^60 - 1), all valid Stream IDs of that type can be used."?

> @@ -849,7 +849,9 @@ initial_stream_id_for_type) can be opened (see {{long-packet-types}}).  Initial
 limits are set in the transport parameters (see
 {{transport-parameter-definitions}}) and subsequently limits are advertised
 using MAX_STREAMS frames ({{frame-max-streams}}). Separate limits apply to
-unidirectional and bidirectional streams.
+unidirectional and bidirectional streams.  If the maximum stream ID that can
+be opened is greater than 2^62 - 1, then the receiver MUST interpret it no

```suggestion
be opened is greater than 2^62 - 1, then the receiver MUST interpret it as no
```

> @@ -849,7 +849,9 @@ initial_stream_id_for_type) can be opened (see {{long-packet-types}}).  Initial
 limits are set in the transport parameters (see
 {{transport-parameter-definitions}}) and subsequently limits are advertised
 using MAX_STREAMS frames ({{frame-max-streams}}). Separate limits apply to
-unidirectional and bidirectional streams.
+unidirectional and bidirectional streams.  If the maximum stream ID that can
+be opened is greater than 2^62 - 1, then the receiver MUST interpret it no
+stream limit and the receiver MUST NOT close the connection.

I don't think this says quite what you mean -- I can send you a MAX_STREAMS frame with a very large value and prohibit you from closing the connection thereafter?  Of course, the only way to violate that prohibition is to close the connection, and the only punishment is to close the connection, so this would be entirely toothless even if it were what you meant.

```suggestion
stream limit; this MUST NOT be treated as an error.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2486#pullrequestreview-208722466