Re: [quicwg/base-drafts] Improve language on evictable entries. (#3131)

afrind <notifications@github.com> Tue, 11 February 2020 23:14 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 79AB2120826 for <quic-issues@ietfa.amsl.com>; Tue, 11 Feb 2020 15:14:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gHkl4aUAe07n for <quic-issues@ietfa.amsl.com>; Tue, 11 Feb 2020 15:14:08 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C3D31120830 for <quic-issues@ietf.org>; Tue, 11 Feb 2020 15:14:07 -0800 (PST)
Date: Tue, 11 Feb 2020 15:14:06 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1581462846; bh=w8fbEvfZbrdQA3X/LOmu7jUbvysUqWzKDdhjXEMsPws=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=n/wug/8qmRsLXfTblV521QJaRlKk6qW9cXQtSVgpWAEegXZUX2Mwl8vTx10LJ3iSm +6fbQdQg8WH+3JLPH9e3JCBmHF+uP/bORVP8hKmEnMCFCwc42bHboIr0PkdLC3rBZ4 pXsMacYHmuPcXLDIez89gocdPO6FOormWvJRSqhE=
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYNQOKBDHR3E5PLUYF4KBT35EVBNHHB45IJ64@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3131/review/357065437@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3131@github.com>
References: <quicwg/base-drafts/pull/3131@github.com>
Subject: Re: [quicwg/base-drafts] Improve language on evictable entries. (#3131)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e43353e65d6d_75d13fcb5f6cd96813231a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/D_WaBDSAp_8mrHOEFok2zNDbD8E>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Feb 2020 23:14:10 -0000

afrind commented on this pull request.

Sorry this got ignored for so long.  Can you rebase it and I can merge it?  There's one minor comment inline

>  ### Limits on Dynamic Table Insertions {#blocked-insertion}
 
 Inserting entries into the dynamic table might not be possible if the table
 contains entries which cannot be evicted.
 
 A dynamic table entry cannot be evicted immediately after insertion, even if it
 has never been referenced. Once the insertion of a dynamic table entry has been
-acknowledged and there are no outstanding unacknowledged references to the
-entry, the entry becomes evictable.
+acknowledged and there are no outstanding references to the entry in
+unacknowledged header blocks, the entry becomes evictable.  Note that
+unacknowledged references on the encoder stream do not preclude the eviction of

I don't know that we need to say this, since the previous sentence explicitly says 'references to the entry in unacknowledged header blocks' and header blocks do not appear on the encoder stream.

Or maybe the sentence should just indicate that headers on the encoder stream that reference other headers do not count as a reference.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3131#pullrequestreview-357065437