Date: Mon, 05 Nov 2018 12:42:09 -0800
From: Matt Olson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4aba6be9d0e6169b08370eecfde8dc3dce64770ecd792cf0000000117f86d2192a169ce167cded5@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1965/c436027365@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1965@github.com>
References: <quicwg/base-drafts/pull/1965@github.com>
Subject: Re: [quicwg/base-drafts] Prevent an unlikely deadlock (#1965)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5be0ab218a580_3a9f3fbade8d45b81330f2";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/DdWC1Gr_HNgIZUyUFrdIEPwVJYQ>


----==_mimepart_5be0ab218a580_3a9f3fbade8d45b81330f2
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

Rather than adding a new paragraph to patch the hole, I'd update the description of what a "probe" packet is. Currently it's "a packet which is not subject to CC and which contains unsent data (if possible) or sent data (otherwise)."

I'd update this sentence and move it somewhere to apply to both TLP and RTO probes.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1965#issuecomment-436027365
----==_mimepart_5be0ab218a580_3a9f3fbade8d45b81330f2
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p>Rather than adding a new paragraph to patch the hole, I'd update the d=
escription of what a "probe" packet is. Currently it's "a packet which is=
 not subject to CC and which contains unsent data (if possible) or sent d=
ata (otherwise)."</p>
<p>I'd update this sentence and move it somewhere to apply to both TLP an=
d RTO probes.</p>

<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/1965#issuecomment-436027365">view it on GitHub</a>, o=
r <a href=3D"https://github.com/notifications/unsubscribe-auth/AWbkq8uYsL=
HHWBnfBl10WxbXOPBIlPtKks5usKKhgaJpZM4YN6nK">mute the thread</a>.<img src=3D=
"https://github.com/notifications/beacon/AWbkq7qzehEind157TXzZ3v_TcboEHEr=
ks5usKKhgaJpZM4YN6nK.gif" height=3D"1" width=3D"1" alt=3D"" /></p>
<script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_versio=
n":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name"=
:"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"=
quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"http=
s://assets-cdn.github.com/images/email/message_cards/header.png","avatar_=
image_url":"https://assets-cdn.github.com/images/email/message_cards/avat=
ar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicw=
g/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@maol=
son-msft in #1965: Rather than adding a new paragraph to patch the hole, =
I'd update the description of what a \"probe\" packet is. Currently it's =
\"a packet which is not subject to CC and which contains unsent data (if =
possible) or sent data (otherwise).\"\r\n\r\nI'd update this sentence and=
 move it somewhere to apply to both TLP and RTO probes."}],"action":{"nam=
e":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/=
1965#issuecomment-436027365"}}}</script>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/1965#issuecomment-4=
36027365",
"url": "https://github.com/quicwg/base-drafts/pull/1965#issuecomment-4360=
27365",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [quicwg/base-drafts] Prevent an unlikely deadlock (#1965)",=

"sections": [
{
"text": "",
"activityTitle": "**Matt Olson**",
"activityImage": "https://assets-cdn.github.com/images/email/message_card=
s/avatar.png",
"activitySubtitle": "@maolson-msft",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \=
"quicwg/base-drafts\",\n\"issueId\": 1965,\n\"IssueComment\": \"{{IssueCo=
mment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\=
": \"quicwg/base-drafts\",\n\"pullRequestId\": 1965\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/1965#issuecomment-4360=
27365"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 4063011=
30\n}"
}
],
"themeColor": "26292E"
}
]</script>=

----==_mimepart_5be0ab218a580_3a9f3fbade8d45b81330f2--