IETF Logo Mail Archive

Re: [quicwg/base-drafts] Move Generating Acknowledgements to Transport (#2916)

Jana Iyengar <notifications@github.com> Wed, 11 September 2019 19:50 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 884001201CE for <quic-issues@ietfa.amsl.com>; Wed, 11 Sep 2019 12:50:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id czOeKiMERM0V for <quic-issues@ietfa.amsl.com>; Wed, 11 Sep 2019 12:50:14 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C0D21120018 for <quic-issues@ietf.org>; Wed, 11 Sep 2019 12:50:14 -0700 (PDT)
Date: Wed, 11 Sep 2019 12:50:14 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1568231414; bh=6Yy14oV590866MIAavmzTgnNtAzUx3qfvYcN4fETpM0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Q0WSgZs4yCcSn4Z1/QmNEIMUrfa6aM8VMocHSYJuRacz7bT+feMoDeJTeh+cYH7Kk fuHW7wPn1QM4tIGzxLM5qrQ1XmHYY3r4Fjf7pNW75s6zGxhW3kzAuD6bl2QjrRySs+ YpF8ugS1Zhr1iCAlyMS9app6h1r0eckVibg5gjPg=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2GEV5HXFE3EVL4CWN3Q2IINEVBNHHBYD42OI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2916/review/287032284@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2916@github.com>
References: <quicwg/base-drafts/pull/2916@github.com>
Subject: Re: [quicwg/base-drafts] Move Generating Acknowledgements to Transport (#2916)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d794ff684ca_7e973fbe12acd9647499"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Dlo-___REIuAqx04y_JzWAg0J_I>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Sep 2019 19:50:17 -0000

janaiyengar commented on this pull request.

@ianswett @martinthomson PTAL

>  ### Sending ACK Frames
 
-An endpoint sends ACK frames to acknowledge packets it has received and
-processed.
+An ACK frame SHOULD be sent immediately upon receipt of a second ack-eliciting
+packet. Loss detection does not assume that the peer sends an ACK immediately on
+receiving a second ack-eliciting packet.

Ok, a few changes, look at the last commit. I've moved some text around and I think I've captured the spirit of this more clearly.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2916#pullrequestreview-287032284

v2.23.0 | Report a Bug | By Email