[quicwg/base-drafts] Persistent Congestion Time Threshold (#2365)

Nick Banks <notifications@github.com> Wed, 23 January 2019 15:53 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 878A912DD85 for <quic-issues@ietfa.amsl.com>; Wed, 23 Jan 2019 07:53:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.553
X-Spam-Level:
X-Spam-Status: No, score=-7.553 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AyJf3sH-vgc7 for <quic-issues@ietfa.amsl.com>; Wed, 23 Jan 2019 07:53:12 -0800 (PST)
Received: from o11.sgmail.github.com (o11.sgmail.github.com [167.89.101.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A1497124C04 for <quic-issues@ietf.org>; Wed, 23 Jan 2019 07:53:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=M9QtAub0vsF1XLCVOT0IG/sZ7Xo=; b=jdHlbD3eW02EqhqN LPEN5NZXb0w0DiSx1ytZ2y4eedU2WW8Ub9Gi2N43nni5oNQ4MRRfigHhbv+9UKIz zOUFb22/Zh5zbs3I6YfZQx+u2r9GBP2zBacbOZt5rZ/Ww3toaTgBcF21Zf7UEFCj vg3IuIttsf6UltvXWQhcCfucf+k=
Received: by filter0356p1iad2.sendgrid.net with SMTP id filter0356p1iad2-18739-5C488DE6-A 2019-01-23 15:53:10.512540738 +0000 UTC m=+389540.019561094
Received: from github-lowworker-baaab27.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id IyKRm9TMQvCXlKJmIrsXOw for <quic-issues@ietf.org>; Wed, 23 Jan 2019 15:53:10.393 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-baaab27.cp1-iad.github.net (Postfix) with ESMTP id 5B496803AF for <quic-issues@ietf.org>; Wed, 23 Jan 2019 07:53:10 -0800 (PST)
Date: Wed, 23 Jan 2019 15:53:11 +0000
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab106f7f175f1a16a85c7d55f470bc29dfca950b5a92cf0000000118604fe692a169ce17fab1f6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2365@github.com>
Subject: [quicwg/base-drafts] Persistent Congestion Time Threshold (#2365)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c488de659b9e_69c13f90accd45c0111923"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3npUIIz9p2kJJCe1DcM8Dq3cRI8wYxHty04K y2eIgmGFlIPnS0MrfPk/MXAeM3NJlNfUA9Rk0pJOdM6s7/0bc//X1/Ayx2JxAmU+XHFh9p+b+KG9Rk sQxYKlSlVZ+DHnB/rinJrQp6UL4hPnIWNCQfMDNnySto8CSvkuoukqEGq58qHjZw8F1QTV8GsASF5k U=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Dsg3ONBNHdnn-uUNb-yzbuGYha0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jan 2019 15:53:15 -0000

Updates the persistent congestion logic to be time based instead of PTO count based, to account for the cases where PTOs don't actually occur.

This is the simplest change I could come up with that fixes the main issue, though I think a completely separate timer would still be better than piggy-backing off the `CongestionEvent`. For instance, in the case the app is periodically sending (and therefore no PTOs occur), if the ACK eventually comes much later than when persistent congestion occurs (or should occur) the CC window only decreases when the ACK arrives; not when persistent congestion started. If you have a separate timer for persistent congestion the window could be reduced immediately instead of waiting for the ACK. For now, though, I chose to go with the simpler change/solution that still mostly gets the job done.
You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/2365

-- Commit Summary --

  * Persistent Congestion Time Threshold

-- File Changes --

    M draft-ietf-quic-recovery.md (40)

-- Patch Links --

https://github.com/quicwg/base-drafts/pull/2365.patch
https://github.com/quicwg/base-drafts/pull/2365.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2365