Re: [quicwg/base-drafts] Adds text about server padding handshake to PMTU (#1013)

[Martin Thomson <[e-mail]>]

martinthomson requested changes on this pull request.



>  
 Servers MUST ignore an initial plaintext packet from a client if its total size
 is less than 1200 octets.
 
+Similarly, servers MUST ensure that the first handshake packet they send to

Use capital H here and maybe be more explicit.  A Version Negotiation or Retry packet shouldn't be larger, and in fact should be kept small.  (We can't pad Version Negotiation anyway, except with greasing values, which isn't much use.)

>  
 Servers MUST ignore an initial plaintext packet from a client if its total size
 is less than 1200 octets.
 
+Similarly, servers MUST ensure that the first handshake packet they send to
+clients, and any retransmissions of those octets, has a QUIC packet size that is
+the same as the received initial client packet, unless the server knows the PMTU
+to the client to be smaller. Sending a packet of this size ensures that the

This "smaller" clause here means that the server-to-client path could end up with a PMTU less than 1200.  I think that you need to set a minimum of 1200 here explicitly.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1013#pullrequestreview-83329831