Re: [quicwg/base-drafts] Packetization Nits (#2476)

Martin Thomson <notifications@github.com> Fri, 15 February 2019 18:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 488A7130EB9 for <quic-issues@ietfa.amsl.com>; Fri, 15 Feb 2019 10:40:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id THe0xb0iGL4r for <quic-issues@ietfa.amsl.com>; Fri, 15 Feb 2019 10:40:34 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B70A6130EBA for <quic-issues@ietf.org>; Fri, 15 Feb 2019 10:40:30 -0800 (PST)
Date: Fri, 15 Feb 2019 10:40:29 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1550256029; bh=TgmaytzkYwZ4WI1sxqnIz8GxDpGztTPLLgR0dW6ZeE8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=yUIyEislOCnM2P7VqnfeLgOtCDU/aaX6evzjFxcsso+51o+gWPow9AZNN9CqQU7dG qp3EkUxKD57SUCCissrbt7ScBPMnUo3F30btZFA+pAdUo6a43g+xtbnSXfVDk6czNK a8MABNda1eQ8NBLgcN1swqQdPUNGVTNEhd4JDc/Q=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abdea0be77beced92515046c08330bec2fcae8069192cf00000001187ec99d92a169ce187d865e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2476/review/204381526@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2476@github.com>
References: <quicwg/base-drafts/pull/2476@github.com>
Subject: Re: [quicwg/base-drafts] Packetization Nits (#2476)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c67079d62632_4bb23fd61a2d45bc2544b3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/DweWs99rKoxoDtr1GWru9kb-iJc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Feb 2019 18:40:36 -0000

martinthomson approved this pull request.

All good apart from the MUST NOT. 

> @@ -2594,7 +2594,7 @@ MUST attempt to process the remaining packets.
 
 Retry packets ({{packet-retry}}), Version Negotiation packets
 ({{packet-version}}), and packets with a short header ({{short-header}}) do not
-contain a Length field and so cannot be followed by other packets in the same
+contain a Length field and so MUST NOT be followed by other packets in the same

I prefer cannot. It isn't an interoperability requirement that these not be followed by anything else, it is an outright impossibility.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2476#pullrequestreview-204381526