Re: [quicwg/base-drafts] Allow not creating QPACK codec streams (#2529)

Lucas Pardue <notifications@github.com> Wed, 20 March 2019 23:20 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 930871277E5 for <quic-issues@ietfa.amsl.com>; Wed, 20 Mar 2019 16:20:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.001
X-Spam-Level:
X-Spam-Status: No, score=-3.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K5iANWmpTbqc for <quic-issues@ietfa.amsl.com>; Wed, 20 Mar 2019 16:20:57 -0700 (PDT)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B351C12D4E6 for <quic-issues@ietf.org>; Wed, 20 Mar 2019 16:20:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=mwbvDpIVTCYcCY4DQ0j/dTJCOSs=; b=eW+umtQp7n3svHv/ /kJkGUgsmYLIuUW4OY0ubGP1aJAFBgXZTCPKVQh7WDjzJKrg3/0sayb+wXdAvRfR FLOo2Hd+BQfg9ligOanJUofYtpox1fmKHQfyiXEGu9K84/eaCciMB0J0MngsVlXY zBTiU7itw37aVUrNTtGInTzRj28=
Received: by filter1007p1las1.sendgrid.net with SMTP id filter1007p1las1-31068-5C92CAD6-27 2019-03-20 23:20:54.793163796 +0000 UTC m=+442176.588766067
Received: from github-lowworker-63e61ec.cp1-iad.github.net (unknown [192.30.252.36]) by ismtpd0023p1iad2.sendgrid.net (SG) with ESMTP id ER73cnJ9T8a72AeX4F3zvQ for <quic-issues@ietf.org>; Wed, 20 Mar 2019 23:20:54.754 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-63e61ec.cp1-iad.github.net (Postfix) with ESMTP id A83BC2A071A for <quic-issues@ietf.org>; Wed, 20 Mar 2019 16:20:54 -0700 (PDT)
Date: Wed, 20 Mar 2019 23:20:54 +0000
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd271c1ec02e6440926e35f5f068c7044453ad1e892cf0000000118aa8cd692a169ce1931c3e6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2529/review/217028445@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2529@github.com>
References: <quicwg/base-drafts/pull/2529@github.com>
Subject: Re: [quicwg/base-drafts] Allow not creating QPACK codec streams (#2529)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c92cad6a6ee9_14973f809acd45c4560276"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2CLv/SdZtuPUtH178ynnv9Yszib/3UYT1QJY EIpGgv/pU0ft6H5+I0mLTnOC8IRyQjaG0qipkQWMApwSfB467H2tyHI3LhVg3SKl66tN+U+u55u6eE 9saL9imn+179hHPjaEa715l8pIvUnf5zs9rdjtKuelsnWLIqjJ/jwWyhEgKfFEbZyBa2ofQ3fXkZaO 0=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Dwi0hrg7CR-tCv18udWZw6r6PTo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Mar 2019 23:21:00 -0000

LPardue commented on this pull request.



>  HTTP_WRONG_STREAM_COUNT. These streams MUST NOT be closed. Closure of either
 unidirectional stream type MUST be treated as a connection error of type
 HTTP_CLOSED_CRITICAL_STREAM.
 
+An endpoint MAY avoid creating its own encoder stream if the maximum size of
+the dynamic table permitted by the peer is zero.
+
+An endpoint MAY avoid creating its own decoder stream if the maximum size of
+its own dynamic table is zero.
+
+An endpoint MUST allow its peer to create both encoder and decoder streams

>  I'm not sure that's such a big deal. If you planned to use the dynamic table, but wasted your stream on grease instead of an encoder stream, then you can't use the table.

The problem is that the sender has no intention of creating an encoder stream but the receiver doesn't know that. If the receiver is eager to use QPACK, it keeps giving back a stream credit for every unidirectional stream that is "wasted" before creating the encoder stream. Even if it didn't give back credit immediately and did let the max uni stream limit be hit, there is no guarantee that the next time the receiver gives credit (say for a push promise) that then it wouldn't spontaneously be used for QPACK. 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2529#discussion_r267583955