Re: [quicwg/base-drafts] Document TCP RTO vs QUIC PTO (#3441)

Martin Thomson <notifications@github.com> Tue, 03 March 2020 23:52 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3F42C3A0885 for <quic-issues@ietfa.amsl.com>; Tue, 3 Mar 2020 15:52:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.1
X-Spam-Level:
X-Spam-Status: No, score=-3.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RG4URdvR9Whg for <quic-issues@ietfa.amsl.com>; Tue, 3 Mar 2020 15:52:16 -0800 (PST)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 11B393A087F for <quic-issues@ietf.org>; Tue, 3 Mar 2020 15:52:14 -0800 (PST)
Date: Tue, 03 Mar 2020 15:52:14 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1583279534; bh=TGvsBq3RU1MYjn3LcnCtUua2+I+C59bClUWEO0umgGU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=rP9BeWQUkLc81v1xqIxgaFzxLbClXP4OufktPq1TKlt0uWg8XPEF+8/Z2L5HpKCM/ tOWOl2C5l5zXS8oA+ksWQjrw/zsFBIwAixavvkYULFpzA+OMxZSLD1aX/uRzOf8BfW fhHg7oVr8HW0GmMo24ek3xa9gTA6uPkdInNnw/gw=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3TC7JIUPANKO2BVMV4NLHK5EVBNHHCC7S66M@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3441/review/368409594@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3441@github.com>
References: <quicwg/base-drafts/pull/3441@github.com>
Subject: Re: [quicwg/base-drafts] Document TCP RTO vs QUIC PTO (#3441)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e5eedae35505_2b173fd4ca8cd96011597f"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/E6zO6QeFFZ3KEg63YWZwFAnIlFs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Mar 2020 23:52:25 -0000

martinthomson approved this pull request.



> @@ -228,6 +228,25 @@ QUIC endpoints measure the delay incurred between when a packet is received and
 when the corresponding acknowledgment is sent, allowing a peer to maintain a
 more accurate round-trip time estimate (see Section 13.2 of {{QUIC-TRANSPORT}}).
 
+### Probe Timeout Replaces RTO and TLP
+
+QUIC uses a probe timeout (see {{pto}}), with a timer based on TCP's RTO
+computation.  QUIC's PTO includes the peer's maximum expected acknowledgement
+delay instead of using a fixed minimum timeout. Unlike TCP, which collapses
+the congestion window upon expiry of an RTO, QUIC does not collapse the
+congestion window until persistent congestion {{persistent-congestion}} is

```suggestion
congestion window until persistent congestion ({{persistent-congestion}}) is
```

> @@ -228,6 +228,25 @@ QUIC endpoints measure the delay incurred between when a packet is received and
 when the corresponding acknowledgment is sent, allowing a peer to maintain a
 more accurate round-trip time estimate (see Section 13.2 of {{QUIC-TRANSPORT}}).
 
+### Probe Timeout Replaces RTO and TLP
+
+QUIC uses a probe timeout (see {{pto}}), with a timer based on TCP's RTO
+computation.  QUIC's PTO includes the peer's maximum expected acknowledgement
+delay instead of using a fixed minimum timeout. Unlike TCP, which collapses
+the congestion window upon expiry of an RTO, QUIC does not collapse the
+congestion window until persistent congestion {{persistent-congestion}} is
+declared and instead allows probe packets to temporarily exceed the congestion
+window whenever the timer expires.  In practice, this is similar to TCP with
+F-RTO, but it does allow more packets to be sent when the congestion window was

Citation for F-RTO?

> +QUIC specifies a time-based definition (see {{persistent-congestion}}) to
+ensure one or more packets are sent prior to a dramatic decrease in
+congestion window.

```suggestion
QUIC specifies a time-based definition to ensure one or more packets are sent
prior to a dramatic decrease in congestion window; see
{{persistent-congestion}}.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3441#pullrequestreview-368409594