Re: [quicwg/base-drafts] Prohibit PADDING in response to ACK (#3104)

Martin Thomson <> Tue, 22 October 2019 01:50 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 44A6A120ACD for <>; Mon, 21 Oct 2019 18:50:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id U2ZJntfyRZD3 for <>; Mon, 21 Oct 2019 18:49:57 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id DD1FE120AD7 for <>; Mon, 21 Oct 2019 18:49:57 -0700 (PDT)
Received: from ( []) by (Postfix) with ESMTP id 77FA2261577 for <>; Mon, 21 Oct 2019 18:49:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1571708997; bh=xkciGcmlMeyipoYe5T5uua3ip9UM65stFupLyusBBs4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TAXa8gbuQ/mwbJq6YPVPkIHsim+++PJem+oZNG1iGvajJh7vSHSMS+HYkg0vtjE1t 2InTIlZ1yNv+FoBidGqRDip8SHiKkEDBHB8C/6DpdkRT/E1d45etrkfnCvwuNmngK/ qcE5pKngycfujcamiajR+267v+yhypZR/8VEtK9Y=
Date: Mon, 21 Oct 2019 18:49:57 -0700
From: Martin Thomson <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/3104/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Prohibit PADDING in response to ACK (#3104)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dae60453244f_4bfd3ffcebecd95c82818"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Tue, 22 Oct 2019 01:50:00 -0000

martinthomson approved this pull request.

> @@ -3061,14 +3061,13 @@ of doing so.
 Packets containing only ACK frames are not congestion controlled, so there are
 limits on how frequently they can be sent.  An endpoint MUST NOT send more than
-one ACK-frame-only packet in response to receiving an ack-eliciting packet (one
-containing frames other than ACK and/or PADDING).  An endpoint MUST NOT send a
-packet containing only an ACK frame in response to a non-ack-eliciting packet
-(one containing only ACK and/or PADDING frames), even if there are packet gaps
-which precede the received packet. Limiting ACK frames avoids an infinite
-feedback loop of acknowledgements, which could prevent the connection from ever
-becoming idle. However, the endpoint acknowledges non-ack-eliciting packets when
-it sends an ACK frame.
+one ACK-frame-only packet in response to receiving an ack-eliciting packet.  An
+endpoint MUST NOT send a non-ack-eliciting packet in response to a non-ack-
+eliciting packet, even if there are packet gaps which precede the received

A nit:  Though this hyphenation looks sane when presented this way, it won't be guaranteed to render nicely.  It might appear as `non-ack- eliciting` (note the extra space).  I think that you should remove the wrapping on the hyphen.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: