Re: [quicwg/base-drafts] Editorial fixes to ECN text (#2189)

janaiyengar <notifications@github.com> Tue, 18 December 2018 22:08 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7C974129BBF for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 14:08:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.064
X-Spam-Level:
X-Spam-Status: No, score=-8.064 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KLq6w6qn4vho for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 14:08:40 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A2F7A126F72 for <quic-issues@ietf.org>; Tue, 18 Dec 2018 14:08:40 -0800 (PST)
Date: Tue, 18 Dec 2018 14:08:39 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545170919; bh=2ZNSnc7dv/izK96+DaRt+ZhZSi5p7KeTi5lka+rA3H4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=fCRtFX8azpISMqjH4M+/f06RTayWnzsSeEZrPhLfB+NsxGBdnsxRcJwOJtXJN+vaQ j5AQjuFzWppAnw1oQUZOTLnqpAYngQX9X4O/yGIMPLB8G7QZ7Zg2bKyg6K6yTQ6J10 0dUQ4+lDdNC0/jAkKI6tVBLq3K8RnnE8dy7gKVEA=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2f8cff6735cd000f3e939fe315b96980d20209f592cf00000001183131e792a169ce17535656@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2189/review/186305629@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2189@github.com>
References: <quicwg/base-drafts/pull/2189@github.com>
Subject: Re: [quicwg/base-drafts] Editorial fixes to ECN text (#2189)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c196fe7ca176_29bf3f9678cd45bc1006d0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/EHcN_933gPirflqscZpfU5lT_nY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Dec 2018 22:08:43 -0000

janaiyengar commented on this pull request.



> @@ -3031,33 +3031,28 @@ an ACK frame without ECN feedback, the endpoint stops setting ECT codepoints in
 subsequent IP packets, with the expectation that either the network path or the
 peer no longer supports ECN.
 
-To reduce the risk of non-standard compliant ECN markings affecting the
-operation of an endpoint, an endpoint verifies the counts it receives when it
-receives new acknowledgements:
+Network devices that corrupt or apply non-standard ECN markings might result in
+reduced throughput or other undesirable side-effects.  To reduce this risk, an
+endpoint uses the following steps to verify the counts it receives in an ACK
+frame.  Note that the counts MUST NOT be verified if the ACK frame does not

We can add a requirement that a receiver MUST NOT decrease the largest acked. I cannot see a reason (let alone a good one) why a receiver would do this. QUIC does not allow reneging of acked data, so decreasing the largest acked is strictly bad. That resolves this issue, right?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2189#discussion_r242724075