Re: [quicwg/base-drafts] Merge ACK and ACK_ECN in recovery (#1783)
Nick Banks <notifications@github.com> Thu, 20 September 2018 23:25 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 824BB12DD85 for <quic-issues@ietfa.amsl.com>; Thu, 20 Sep 2018 16:25:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z_JtQ-AKZFFP for <quic-issues@ietfa.amsl.com>; Thu, 20 Sep 2018 16:25:51 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8393F128BAC for <quic-issues@ietf.org>; Thu, 20 Sep 2018 16:25:51 -0700 (PDT)
Date: Thu, 20 Sep 2018 16:25:50 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1537485950; bh=hLiOP2nbmKFHI2EGhy+QdDLOK5HNJ+ejoRtjw6RYjAg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oSZgs5Mks76KHkTR1DuL8U9dStRvweg1no36jJRDTJ0MYpKyaAGIYwrf2YBWTQ8P/ efZKASXbY09NPTU2PD25PI6Q3N3V8mmsiR5WndhRT28Wuhg8AMmKDkVmuGbj6Ye/lR pmmvYHxm33YvHJlaDx8agK/mcRQ6O2dvNAKDP0to=
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab1ee263e58238aefb802b4dfbddaa08278e015aa292cf0000000117bbee7e92a169ce1599cf69@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1783/review/157501911@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1783@github.com>
References: <quicwg/base-drafts/pull/1783@github.com>
Subject: Re: [quicwg/base-drafts] Merge ACK and ACK_ECN in recovery (#1783)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ba42c7e7413d_395c3ff3006d45c4995d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/EJg27TdjGZNVPL7YUC0D-UH-qXQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Sep 2018 23:25:54 -0000
nibanks commented on this pull request. > @@ -105,7 +100,7 @@ In-flight: Retransmittable Frames: -: All frames besides ACK, ACK_ECN, or PADDING are considered +: All frames besides ACK, or PADDING are considered Is the `,` needed any more? Also, this can all fit on a single line now, right? > @@ -133,13 +128,13 @@ acknowledged or declared lost and sent in new packets as necessary. The types of frames contained in a packet affect recovery and congestion control logic: * All packets are acknowledged, though packets that contain only ACK, - ACK_ECN, and PADDING frames are not acknowledged immediately. Looks like the `,` after ACK isn't needed here either. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1783#pullrequestreview-157501911
- [quicwg/base-drafts] Merge ACK and ACK_ECN in rec… ianswett
- Re: [quicwg/base-drafts] Merge ACK and ACK_ECN in… Nick Banks
- Re: [quicwg/base-drafts] Merge ACK and ACK_ECN in… ianswett
- Re: [quicwg/base-drafts] Merge ACK and ACK_ECN in… ianswett
- Re: [quicwg/base-drafts] Merge ACK and ACK_ECN in… MikkelFJ
- Re: [quicwg/base-drafts] Merge ACK and ACK_ECN in… martinduke
- Re: [quicwg/base-drafts] Merge ACK and ACK_ECN in… Martin Thomson
- Re: [quicwg/base-drafts] Merge ACK and ACK_ECN in… Martin Thomson