Re: [quicwg/base-drafts] introduce a max_connection_ids transport parameter (#1998)

Mike Bishop <notifications@github.com> Thu, 07 February 2019 18:59 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 14575124C04 for <quic-issues@ietfa.amsl.com>; Thu, 7 Feb 2019 10:59:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3
X-Spam-Level:
X-Spam-Status: No, score=-3 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7yfhIj9XWtLC for <quic-issues@ietfa.amsl.com>; Thu, 7 Feb 2019 10:59:12 -0800 (PST)
Received: from o8.sgmail.github.com (o8.sgmail.github.com [167.89.101.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 131C412426E for <quic-issues@ietf.org>; Thu, 7 Feb 2019 10:59:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=/Sewgsu0ArTZqesAaNnuWNmZ6pk=; b=F1PgYyavNotvIrR8 2EBai9GYIkaAFWOUpv8wjBInAw+4pyk0fOYVw9cHxvcdpMTa9Kq6PEzxxgfvb870 fIXajrH40NyDBqbJbfug/Z1lsNx31tiegoqOVXKL8FV2JeLja5oQm6EOjBNMCtXu 1n8/Hegp2lZxR8oRfNtXW/RGPSg=
Received: by filter0758p1las1.sendgrid.net with SMTP id filter0758p1las1-29699-5C5C7FFF-5 2019-02-07 18:59:11.103556493 +0000 UTC m=+169604.351088971
Received: from github-lowworker-baaab27.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id Aq8R7e5IQ1quobo7hLHByg for <quic-issues@ietf.org>; Thu, 07 Feb 2019 18:59:10.995 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-baaab27.cp1-iad.github.net (Postfix) with ESMTP id F128A804B6 for <quic-issues@ietf.org>; Thu, 7 Feb 2019 10:59:10 -0800 (PST)
Date: Thu, 07 Feb 2019 18:59:11 +0000 (UTC)
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abeb086deca64b90625d672ffb6542ba52feb7745692cf00000001187441fe92a169ce16a7e5d6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1998/review/201265555@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1998@github.com>
References: <quicwg/base-drafts/pull/1998@github.com>
Subject: Re: [quicwg/base-drafts] introduce a max_connection_ids transport parameter (#1998)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5c7ffeeeed0_4dfb3fef070d45b8144099"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak08ZF/79sIAYsKxiJtQa8vlEZ4/XTyzgrgduC 0HH2Rgwo/oiq4x5C26v7sK0kSuuXF/LBpzw1LVOnOQGZHJEebYqHx4hahYxX9ZsP0PhMyhEa1nBh80 kxrNX5z+84VOUD1lJbgTsbEavdRS2D7PxougkDzQf7uVymwLqdZ0+lZcVdnSAKACUThpBc/YaleMf/ 0=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ENlEFGA1EzmK1gQskaNgS9fA0_s>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Feb 2019 18:59:14 -0000

MikeBishop commented on this pull request.



> @@ -3981,6 +3979,12 @@ A client MUST NOT include an original connection ID, a stateless reset token, or
 a preferred address.  A server MUST treat receipt of any of these transport
 parameters as a connection error of type TRANSPORT_PARAMETER_ERROR.
 
+max_connection_ids (0x000e):
+
+: The maximum number of connection IDs that the peer is willing to store.
+  This value includes only connection IDs sent in NEW_CONNECTION_ID frames.

Iff you count the handshake and SPA CIDs, an overflow just from transport parameters is possible if set to 0/1, as @marten-seemann pointed out earlier.  Overflows are also possible based on the advice to replace upon seeing a new CID enter use, though I think that's best addressed by just not recommending/allowing that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1998#discussion_r254823526