[quicwg/base-drafts] OnPacketAcked issue (#1774)

Lars Eggert <notifications@github.com> Wed, 19 September 2018 17:48 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B1A671310AE for <quic-issues@ietfa.amsl.com>; Wed, 19 Sep 2018 10:48:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.009
X-Spam-Level:
X-Spam-Status: No, score=-3.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jXWteg1af5bZ for <quic-issues@ietfa.amsl.com>; Wed, 19 Sep 2018 10:48:31 -0700 (PDT)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E0089131111 for <quic-issues@ietf.org>; Wed, 19 Sep 2018 10:48:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=zxki5l7nAN+Vv58BqFje/hcDsVE=; b=i05+/ZSYiRAr6gLo WAK04tRq0vU7XEoGSsrBrAU+6vbWCEKNcr31wkqeC0n+ZebIx0IYcSavueky9ZmX /8wdDIz27Zkq4bdps8rzTmUeoY5hK2dSivRm4G8kkAa9VZT4x4IBgD6x6hZrqejj e0QNiDr3MyvOFNej34A4tB+EhxQ=
Received: by filter1216p1las1.sendgrid.net with SMTP id filter1216p1las1-22317-5BA28BEA-1B 2018-09-19 17:48:26.930261405 +0000 UTC m=+1108684.232281709
Received: from github-lowworker-5909e27.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id FV1WyQyKQ2-wfFLEaUgNYg for <quic-issues@ietf.org>; Wed, 19 Sep 2018 17:48:26.830 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-5909e27.cp1-iad.github.net (Postfix) with ESMTP id C8B273E0D20 for <quic-issues@ietf.org>; Wed, 19 Sep 2018 10:48:26 -0700 (PDT)
Date: Wed, 19 Sep 2018 17:48:27 +0000
From: Lars Eggert <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab110b37bc214ca0e61c9571d341fd9993b9641a1d92cf0000000117ba4dea92a169ce159180b3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1774@github.com>
Subject: [quicwg/base-drafts] OnPacketAcked issue (#1774)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ba28beac0051_29f53f92e50d45b41274ca"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: larseggert
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0NFzRFhu/knvGzAk7/rfmh8zH1nuqu/dUR6Q 9JBQgKnq3+46lpyyLbiOugahRGGzeGY7122zzexrJ2Wi245PE1KUtKEAWhamAiGnWuQQ6feHNv+GrO Ot/+bKGuHaORPJuts9bJWlJWjxZZYk20N1wsBb7RhQDm5tOtxq1CFm/DbcHNft67Y7x5sEWyDlHvqH g=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/EPGN24KuoP92ozE4hkRjihJAac8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Sep 2018 17:48:36 -0000

Issue for what I described to @ianswett at dinner yesterday.

When `OnRetransmissionTimeoutVerified` is called from `OnPacketAcked` for the highest ACK in a block, all earlier packets are marked as lost, even if they are contained in that same block. That seems suboptimal.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1774