Re: [quicwg/base-drafts] Additional error cases for CANCEL_PUSH (#3083)

Mike Bishop <notifications@github.com> Fri, 11 October 2019 15:16 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A89FC12008D for <quic-issues@ietfa.amsl.com>; Fri, 11 Oct 2019 08:16:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.596
X-Spam-Level:
X-Spam-Status: No, score=-1.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cLDRyKjYCSj7 for <quic-issues@ietfa.amsl.com>; Fri, 11 Oct 2019 08:16:28 -0700 (PDT)
Received: from o10.sgmail.github.com (o10.sgmail.github.com [167.89.101.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8EB36120073 for <quic-issues@ietf.org>; Fri, 11 Oct 2019 08:16:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=NF2Z5IOiGlsr7mj0vCWhG6mflQA=; b=ry9BP0+uZ98N0VLZ J0YLRic3F8pEhNuTg0+aAr8nEHHBoUgnFXUqibM060gocBYDnwCZwGizyO5nhh6h qrIKqYrs2WKZGOb4xlH+Y7DSB9P2HzoRtV4U8duJI4XtZewMxRNu4GGgVFMDVsKB K9cTX7UltEJvMUasoqkJNTsoOEU=
Received: by filter0863p1las1.sendgrid.net with SMTP id filter0863p1las1-30915-5DA09CCB-B 2019-10-11 15:16:27.118595617 +0000 UTC m=+55670.235181018
Received: from github-lowworker-baaab27.cp1-iad.github.net (unknown [140.82.115.14]) by ismtpd0074p1iad2.sendgrid.net (SG) with ESMTP id adtuOWspRpOrMbu9hM8PNQ for <quic-issues@ietf.org>; Fri, 11 Oct 2019 15:16:26.992 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-baaab27.cp1-iad.github.net (Postfix) with ESMTP id E52E88050F for <quic-issues@ietf.org>; Fri, 11 Oct 2019 08:16:26 -0700 (PDT)
Date: Fri, 11 Oct 2019 15:16:27 +0000 (UTC)
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3V5VHR6BEHFCE4CKF3VXOVVEVBNHHB4DMTGA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3083/review/300755650@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3083@github.com>
References: <quicwg/base-drafts/pull/3083@github.com>
Subject: Re: [quicwg/base-drafts] Additional error cases for CANCEL_PUSH (#3083)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da09ccae3a50_4e973fd2540cd9687224e"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2TVIVhNIfUm9vGEMCreEHOaeNDnIyh9eejpr nSYAHSBDhNWaHIJecdoGMoY9pOqKiiEZfO8Z7T69okbiDI6iFhGbFtnbkcVYBe6EjL9bQnCmAuFbXy Mif1Zmh/jwDw6Dyi5AvIhesgii9KBUjNqhFwhWFM1L0jEFof9FQ7KmEgNowS/gRw5+xl23bOvi5nQ7 s=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/EQnIEplohdNjfCgqBBUPdFr8y0E>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Oct 2019 15:16:31 -0000

MikeBishop commented on this pull request.



> @@ -1093,10 +1094,15 @@ error of type HTTP_FRAME_UNEXPECTED.
 
 The CANCEL_PUSH frame carries a Push ID encoded as a variable-length integer.
 The Push ID identifies the server push that is being cancelled (see
-{{frame-push-promise}}).
+{{frame-push-promise}}).  If a CANCEL_PUSH frame is received which references a
+Push ID greater than currently allowed on the connection, this MUST be treated

The server can issue a CANCEL_PUSH for a push it wasn't allowed to send, which the client should treat as an error.  And since CANCEL_PUSH and MAX_PUSH_ID are on the control stream, if the client uses a Push ID greater than it has permitted, that also seems invalid.

However, in the latter case, I can believe there are implementations where that ordering isn't maintained within the client, so perhaps we should relax that one.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3083#discussion_r334043260