Re: [quicwg/base-drafts] Restore CID sequence numbers (#1465)

Martin Thomson <notifications@github.com> Sun, 24 June 2018 23:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1B6A0130E78 for <quic-issues@ietfa.amsl.com>; Sun, 24 Jun 2018 16:40:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eGN62ztEMhse for <quic-issues@ietfa.amsl.com>; Sun, 24 Jun 2018 16:40:57 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 56A04130E72 for <quic-issues@ietf.org>; Sun, 24 Jun 2018 16:40:57 -0700 (PDT)
Date: Sun, 24 Jun 2018 16:40:56 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1529883656; bh=jxjvaoCiXV7Koc8HLvkZk9TmdDWnODtUtMZVpwxN2Ys=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=xDFcHEYR784K0cnH072BRyLNi7FE2WRRZaBo4sgv+Y+Uu2tgdFvryg+dC+h3+TY6z EqZsas7rP7ZB1SAy3igvsenXVwcBkH+bpZdUu/YBGpZHWEYObRyF1udG7ZF0TpY9IX p3P7LVBbC8EBGbMS0MReOLKm3St02Qp3g7uMCX6Y=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab36792abdd85401a55c40fb2e1edadaf21ad41a8192cf000000011747ee0892a169ce13ec6080@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1465/review/131440824@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1465@github.com>
References: <quicwg/base-drafts/pull/1465@github.com>
Subject: Re: [quicwg/base-drafts] Restore CID sequence numbers (#1465)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b302c08a9f2b_dda2acba61f2f6053710"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/EVLzRZBchzKJEgxxDf5tUCA0aTo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Jun 2018 23:40:59 -0000

martinthomson commented on this pull request.



> @@ -2613,6 +2627,14 @@ The NEW_CONNECTION_ID is as follows:
 
 The fields are:
 
+Sequence:
+
+: A variable-length integer.  This value starts at 0 and increases by 1 for each
+  connection ID that is provided by the server.  The connection ID that is
+  assigned during the handshake is assumed to have a sequence of -1.  That is,

I don't think that would help with the suggestion in #1468.  Insisting on a fixed starting point ensures that you can do things like matching.

Removing the connection ID from the preferred address would make it harder to get that right because you then need to wait for a NEW_CONNECTION_ID frame before migrating.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1465#discussion_r197656872