Re: [quicwg/base-drafts] Use octets rather than bytes throughout (#1912)
MikkelFJ <notifications@github.com> Thu, 25 October 2018 05:07 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B3159130DE4 for <quic-issues@ietfa.amsl.com>; Wed, 24 Oct 2018 22:07:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1bQRGqT46U8r for <quic-issues@ietfa.amsl.com>; Wed, 24 Oct 2018 22:07:45 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DD3D8128CFD for <quic-issues@ietf.org>; Wed, 24 Oct 2018 22:07:44 -0700 (PDT)
Date: Wed, 24 Oct 2018 22:07:43 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540444063; bh=GH+TVe3PPVOuem4pVha1UOu5oP+zBcyYrgClOd6AjnY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=NHrC2n/9tGxEdslUt+pYx+VHwOr7YTlEr3xjCy4fRFAJt3Q1DTPo+fv62mcDD0beD 21uQPauAL/KDQt7t+7/VzjgVLg+8Yiale4M7YIhCqptAXxvai2hY7vgNmSU+TMLASg ToXc7ldL+ssCGiHE75r9lye8M+ir7UPDgj0tLHi4=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abc691e564a2cb3aba85bf7842691351cd17bbd43f92cf0000000117e9119f92a169ce164735c5@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1912/review/168209821@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1912@github.com>
References: <quicwg/base-drafts/pull/1912@github.com>
Subject: Re: [quicwg/base-drafts] Use octets rather than bytes throughout (#1912)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd14f9fb3552_35673fbcce0d45c4107913b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/EY8I4KQkh-2r7lLR2OeJF3ynfM4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Oct 2018 05:07:47 -0000
mikkelfj commented on this pull request. > @@ -618,8 +617,8 @@ sent_packets: : An association of packet numbers to information about them, including a number field indicating the packet number, a time field indicating the time a packet was sent, a boolean indicating whether the packet is ack-only, a boolean - indicating whether it counts towards bytes in flight, and a bytes - field indicating the packet's size. sent_packets is ordered by packet number, + indicating whether it counts towards bytes in flight, and a size field It says bytes in flight -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1912#pullrequestreview-168209821
- [quicwg/base-drafts] Use octets rather than bytes… Martin Thomson
- Re: [quicwg/base-drafts] Use octets rather than b… Martin Thomson
- Re: [quicwg/base-drafts] Use octets rather than b… MikkelFJ
- Re: [quicwg/base-drafts] Use octets rather than b… ianswett
- Re: [quicwg/base-drafts] Use octets rather than b… Nick Banks
- Re: [quicwg/base-drafts] Use octets rather than b… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Use octets rather than b… MikkelFJ
- Re: [quicwg/base-drafts] Use octets rather than b… Martin Thomson
- Re: [quicwg/base-drafts] Use octets rather than b… MikkelFJ
- Re: [quicwg/base-drafts] Use octets rather than b… Martin Thomson
- Re: [quicwg/base-drafts] Use octets rather than b… Martin Thomson
- Re: [quicwg/base-drafts] Use octets rather than b… Mike Bishop
- Re: [quicwg/base-drafts] Use octets rather than b… MikkelFJ
- Re: [quicwg/base-drafts] Use octets rather than b… MikkelFJ