Re: [quicwg/base-drafts] The packet header changed since this was written (#3514)

Kazuho Oku <notifications@github.com> Thu, 12 March 2020 00:36 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0DA123A09A4 for <quic-issues@ietfa.amsl.com>; Wed, 11 Mar 2020 17:36:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.482
X-Spam-Level:
X-Spam-Status: No, score=-1.482 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id srp2WdFTRT0u for <quic-issues@ietfa.amsl.com>; Wed, 11 Mar 2020 17:36:39 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6F4943A09BC for <quic-issues@ietf.org>; Wed, 11 Mar 2020 17:36:38 -0700 (PDT)
Date: Wed, 11 Mar 2020 17:36:37 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1583973397; bh=Upm8YpnIx9TwgdyOEO3qoOW78E2BEyoNX/FQk2yrgrY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=kIsRHjvZLp90vLEoQ+NVNRB7OmIpbUVJQyIMsRRWVS7wR4qrGiUyGyvyK/YEOEc0C VOhwgRwv1R4q0r2GESC5ciD2HoVyAUd0qIB7If13Mx635Dd4FqD0AFOKC1TE4ZtupY ppBzYtH6enObmMZl/Jgop8KTFOsQ0xIl8gDn648g=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK33ATULGLWK3DAFEUF4OVSRLEVBNHHCFDCFKI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3514/review/373212890@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3514@github.com>
References: <quicwg/base-drafts/pull/3514@github.com>
Subject: Re: [quicwg/base-drafts] The packet header changed since this was written (#3514)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e698415863fe_5bda3fd4b5ccd96c1058d7"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Eb5fxbXtsQjXZfnj5dBAa3XFVs0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Mar 2020 00:36:41 -0000

kazuho commented on this pull request.



> @@ -352,7 +352,7 @@ The following statements are NOT guaranteed to be true for every QUIC version:
 * QUIC uses an AEAD (AEAD_AES_128_GCM {{?RFC5116}}) to protect the packets it
   exchanges during connection establishment
 
-* QUIC packet numbers appear after the Version field
+* QUIC packet numbers appear after the connection ID fields

This statement is bit weird, as the packet number field of an Initial packet does not immediately follow the connection ID fields. The field appears after the token field. And I point this out in relation to Initial packets, because IIUC the primary intended reader here are the middlebox developers, who would have the possibility of analyzing Initial packets, but no other packet types with a packet number field.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3514#pullrequestreview-373212890