IETF Logo Mail Archive

Re: [quicwg/base-drafts] Resending ACKs increases max_ack_delay unnecessarily (#1438)

ianswett <notifications@github.com> Thu, 28 June 2018 17:02 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 35177130E9D for <quic-issues@ietfa.amsl.com>; Thu, 28 Jun 2018 10:02:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ujeOyFV1hm3k for <quic-issues@ietfa.amsl.com>; Thu, 28 Jun 2018 10:02:07 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E9FB6130F93 for <quic-issues@ietf.org>; Thu, 28 Jun 2018 10:02:05 -0700 (PDT)
Date: Thu, 28 Jun 2018 10:02:03 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1530205323; bh=hkTr72o3RvsEdDTCGOLYmANYgRJ6ezSC+JF6fbrnJkI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=rWFFYHAw6/YWMluyFp7JDmGVtT1o31M56ja/VmeKVegs0afoi2lUKc/AfK4ZTTbz6 IR7O7srwkvPOvE+/glKSEcgGAzHdFDYBUEd9UwwwG9myL1A+sxgyQf7Ep34gFiCX3M slid81f7NIC80HxCPH7AyRouf2L2aryLnStmb+2w=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab280e84208c504ce3da9772dd890058d18dd0049092cf00000001174cd68b92a169ce13c06cde@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1438/401104787@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1438@github.com>
References: <quicwg/base-drafts/issues/1438@github.com>
Subject: Re: [quicwg/base-drafts] Resending ACKs increases max_ack_delay unnecessarily (#1438)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b35148bd46f9_8fc3fdc645fef80124158"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/EcJz9IK-QcSXnUD_-j6WbyoHidY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jun 2018 17:02:10 -0000

You only increase max_ack_delay if there's a newly acknowledged largest acked packet.  So sending old acks by itself doesn't increase max_ack_delay.

Explicit communication is a way to bound this, and in theory it seems unnecessary, but I suspect adding it could mitigate some very weird edge cases.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1438#issuecomment-401104787

v2.23.0 | Report a Bug | By Email